From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Marek Vasut <marex@denx.de>,
linux-mips@linux-mips.org, Wills Wang <wills.wang@live.com>,
Daniel Schwierzeck <daniel.schwierzeck@gmail.com>,
Alban Bedel <albeu@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter
Date: Fri, 19 Feb 2016 01:11:37 +0300 [thread overview]
Message-ID: <20160219011137.d8f85d72bbaa18c6e206dd09@gmail.com> (raw)
In-Reply-To: <56C60DF8.1060809@cogentembedded.com>
On Thu, 18 Feb 2016 21:31:20 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> On 02/18/2016 09:06 PM, Antony Pavlov wrote:
[...]
> > so I use regulator in the TL-MR3020 board dts file:
> >
> > reg_usb_vbus: reg_usb_vbus {
> > compatible = "regulator-fixed";
> > regulator-name = "usb_vbus";
> > regulator-min-microvolt = <5000000>;
>
> Not 0?
>
> > regulator-max-microvolt = <5000000>;
> > gpio = <&gpio 8 GPIO_ACTIVE_HIGH>;
>
> Where's the switch if both voltages are equal?
Here is a quote from linux/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
Any property defined as part of the core regulator
binding, defined in regulator.txt, can also be used.
However a fixed voltage regulator is expected to have the
regulator-min-microvolt and regulator-max-microvolt
to be the same.
Moreover please see this of_get_fixed_voltage_config() code fragment
(please see linux/drivers/regulator/fixed.c for details):
if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
config->microvolts = init_data->constraints.min_uV;
} else {
dev_err(dev,
"Fixed regulator specified with variable voltages\n");
return ERR_PTR(-EINVAL);
}
--
Best regards,
Antony Pavlov
prev parent reply other threads:[~2016-02-18 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1455005641-7079-1-git-send-email-antonynpavlov@gmail.com>
2016-02-09 8:13 ` [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Antony Pavlov
2016-02-09 11:14 ` Marek Vasut
2016-02-09 22:15 ` Alban
2016-02-10 0:00 ` Antony Pavlov
2016-02-18 16:12 ` Alan Stern
2016-02-18 16:39 ` Marek Vasut
2016-02-18 18:06 ` Antony Pavlov
2016-02-18 18:31 ` Sergei Shtylyov
2016-02-18 22:11 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219011137.d8f85d72bbaa18c6e206dd09@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=albeu@free.fr \
--cc=daniel.schwierzeck@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
--cc=wills.wang@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).