From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757174AbcBSCpe (ORCPT ); Thu, 18 Feb 2016 21:45:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38960 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757006AbcBSCpc (ORCPT ); Thu, 18 Feb 2016 21:45:32 -0500 Date: Thu, 18 Feb 2016 18:45:31 -0800 From: Stephen Boyd To: Andy Shevchenko Cc: Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path Message-ID: <20160219024531.GR4847@codeaurora.org> References: <1455704973-811-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455704973-811-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17, Andy Shevchenko wrote: > diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c > index bdc5e27..43d8066 100644 > --- a/drivers/mfd/intel_quark_i2c_gpio.c > +++ b/drivers/mfd/intel_quark_i2c_gpio.c > @@ -150,11 +150,10 @@ static void intel_quark_unregister_i2c_clk(struct pci_dev *pdev) > { > struct intel_quark_mfd *quark_mfd = dev_get_drvdata(&pdev->dev); > > - if (!quark_mfd->i2c_clk || !quark_mfd->i2c_clk_lookup) > + clk_unregister(quark_mfd->i2c_clk); > + if (!quark_mfd->i2c_clk_lookup) > return; > - > clkdev_drop(quark_mfd->i2c_clk_lookup); It's probably not a great idea to unregister the clk before the lookup is dropped. I suppose nothing too bad will happen though because we handle this case in the framework and substitute dummy ops in place of the real ones. > - clk_unregister(quark_mfd->i2c_clk); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project