From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424816AbcBSEgh (ORCPT ); Thu, 18 Feb 2016 23:36:37 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38962 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424701AbcBSEgg (ORCPT ); Thu, 18 Feb 2016 23:36:36 -0500 Date: Thu, 18 Feb 2016 20:36:35 -0800 From: Greg Kroah-Hartman To: Thierry Reding Cc: devel@driverdev.osuosl.org, "J . German Rivera" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Message-ID: <20160219043635.GA8029@kroah.com> References: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com> <20160218140230.GC3941@ulmo.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218140230.GC3941@ulmo.nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 03:02:30PM +0100, Thierry Reding wrote: > On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > This driver uses functionality (MSI IRQ domain) whose symbols aren't > > exported, and hence the modular build fails. While arguably there might > > be reasons to make these symbols available to modules, that change would > > be fairly involved and the set of exported functions should be carefully > > auditioned. Fix the build failure for now by marking the driver boolean. > > > > Cc: J. German Rivera > > Cc: Greg Kroah-Hartman > > Signed-off-by: Thierry Reding > > --- > > drivers/staging/fsl-mc/bus/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Sorry for being pushy, but this has had allmodconfig builds broken in > linux-next for a couple of days now. The driver has been marked BROKEN > now in linux-next to remedy that, but having proper fixes seems better > than that. Sorry for the delay, now merged, thanks. greg k-h