linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC PATCH 3/3] mm/zsmalloc: change ZS_MAX_PAGES_PER_ZSPAGE
Date: Fri, 19 Feb 2016 13:46:04 +0900	[thread overview]
Message-ID: <20160219044604.GA16230@swordfish> (raw)
In-Reply-To: <20160219041601.GA820@swordfish>

On (02/19/16 13:16), Sergey Senozhatsky wrote:
> ok, this sets us on a  "do we need 32 and 48 bytes classes at all"  track?
> 

seems that lz4 defines a minimum length to be at least

 61 #define COPYLENGTH 8
 67 #define MINMATCH        4
 70 #define MFLIMIT         (COPYLENGTH + MINMATCH)
 71 #define MINLENGTH       (MFLIMIT + 1)

bytes.

and 32 bytes class still looks unreachable.

# cat /sys/kernel/debug/zsmalloc/zram0/classes 
  class  size  huge almost_full almost_empty obj_allocated   obj_used pages_used pages_per_zspage
     0    32             0            0             0          0          0                1
     1    48            26            0         31488      31259        369                3
     2    64             1            0         61760      61756        965                1
     3    80             2            1          2295       2253         45                1
     4    96             4            0          2176       2127         51                3
     5   112             1            1          1387       1358         38                2
     6   128             0            1          1312       1281         41                1
     7   144             1            0          1105       1086         39                3
     8   160             2            2          1173       1137         46                2
     9   176             4            0          1023        995         44                4
    10   192             6            1           960        913         45                3
    11   208             1            1           897        883         46                2
    12   224             1            2           803        735         44                4
    13   240             2            1           799        785         47                1
    14   256             1            1           816        807         51                1
    15   272             1            1           765        758         51                1
    16   288             3            1           840        831         60                1
    17   304             2            1           960        940         72                3
    18   320             1            1          1020        999         80                4
    19   336             2            0          1104       1102         92                1
    20   352             4            1          1265       1247        110                2
    21   368             1            1          1287       1280        117                1
    22   384             2            0          1248       1242        117                3
    23   400             0            0          1380       1380        138                1
    24   416             1            0          1404       1403        144                4
    25   432             0            0          1400       1400        150                3
    26   448             1            0          1278       1277        142                1
    27   464             0            2          1295       1263        148                4
    28   480             4            0          1326       1319        156                2
    29   496             2            2          2343       2311        284                4
    30   512             0            0          1360       1360        170                1
    31   528             0            3          1395       1365        180                4
    32   544             2            1          1320       1306        176                2
    33   560             0            1          1218       1203        168                4
    34   576             0            0          1162       1162        166                1
    35   592             2            1          1053       1033        156                4
    36   608             2            2          1440       1424        216                3
    37   624             0            1          1664       1659        256                2
    38   640             1            1          1197       1186        189                3
    40   672             0            2          2292       2287        382                1
    42   704             3            0          2369       2365        412                4
    43   720             1            1          1207       1198        213                3
    44   736             1            1          1232       1227        224                2
    46   768             1            2          2336       2323        438                3
    49   816             0            0          3615       3615        723                1
    51   848             3            1          2185       2174        460                4
    52   864             1            1          1148       1141        246                3
    54   896             2            2          2889       2881        642                2
    57   944             2            0          3796       3794        876                3
    58   960             2            0          1428       1423        336                4
    62  1024             0            1          5604       5603       1401                1
    66  1088             0            1          6060       6047       1616                4
    67  1104             1            0          1661       1659        453                3
    71  1168             2            0          6440       6438       1840                2
    74  1216             4            0          5120       5115       1536                3
    76  1248             4            0          3536       3531       1088                4
    83  1360             0            1         15282      15281       5094                1
    91  1488             3            1         17897      17887       6508                4
    94  1536             3            1          5768       5762       2163                3
   100  1632             3            1         10275      10270       4110                2
   107  1744             1            1         11676      11673       5004                3
   111  1808             3            0          6714       6711       2984                4
   126  2048             0            2         27758      27756      13879                1
   144  2336             0            5         32823      32807      18756                4
   151  2448             3            2          9650       9642       5790                3
   168  2720             0            8         13341      13326       8894                2
   190  3072             0            3          7804       7799       5853                3
   202  3264             2            0           255        253        204                4
   254  4096 Y           0            0        636960     636960     636960                1

	-ss

  parent reply	other threads:[~2016-02-19  4:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18  3:02 [RFC PATCH 0/3] mm/zsmalloc: increase density and reduce memory wastage Sergey Senozhatsky
2016-02-18  3:02 ` [RFC PATCH 1/3] mm/zsmalloc: introduce zs_get_huge_class_size_watermark() Sergey Senozhatsky
2016-02-18  3:02 ` [RFC PATCH 2/3] zram: use zs_get_huge_class_size_watermark() Sergey Senozhatsky
2016-02-18  3:02 ` [RFC PATCH 3/3] mm/zsmalloc: change ZS_MAX_PAGES_PER_ZSPAGE Sergey Senozhatsky
2016-02-18  4:41   ` Sergey Senozhatsky
2016-02-18  4:46     ` Sergey Senozhatsky
2016-02-18  5:03     ` Sergey Senozhatsky
2016-02-18  8:28   ` Joonsoo Kim
2016-02-18  9:55     ` Sergey Senozhatsky
2016-02-18 10:19       ` Sergey Senozhatsky
2016-02-19  1:19         ` Joonsoo Kim
2016-02-19  4:16           ` Sergey Senozhatsky
2016-02-19  4:19             ` Sergey Senozhatsky
2016-02-19  4:46             ` Sergey Senozhatsky [this message]
2016-02-19  5:38               ` Sergey Senozhatsky
2016-02-19  5:55                 ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219044604.GA16230@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).