From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757453AbcBSNTT (ORCPT ); Fri, 19 Feb 2016 08:19:19 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:47720 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbcBSNTQ (ORCPT ); Fri, 19 Feb 2016 08:19:16 -0500 Date: Fri, 19 Feb 2016 14:19:45 +0100 From: Ludovic Desroches To: Romain Izard CC: , , , Nicolas Ferre , Alexandre Belloni , Linus Walleij , Linux GPIO List Subject: Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node Message-ID: <20160219131945.GX2607@odux.rfo.atmel.com> Mail-Followup-To: Romain Izard , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Linus Walleij , Linux GPIO List References: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455790866-13301-1-git-send-email-romain.izard.pro@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 11:21:06AM +0100, Romain Izard wrote: > All pinctrl nodes for the Atmel pinctrl controller need to have their > bias configuration explicitly defined. Otherwise, the pinctrl mapping > is not valid. > > It works for now as the pinctrl driver proceeds even with invalid > mappings, but this can become an issue, if the pinctrl driver starts > to require valid mappings. Additionally, the pin is not protected from > being remapped later by an other driver. > > There is an external 1kΩ pull-up to 3.3V, so no bias is required on > the Ethernet PHY's interrupt line. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > index e683856c507c..75341eec2dfd 100644 > --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts > @@ -308,6 +308,7 @@ > > pinctrl_macb0_phy_irq: macb0_phy_irq { > pinmux = ; > + bias-disable; > }; > > pinctrl_pdmic_default: pdmic_default { > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html