From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1427724AbcBSPAe (ORCPT ); Fri, 19 Feb 2016 10:00:34 -0500 Received: from imap.thunk.org ([74.207.234.97]:56578 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424800AbcBSPAc (ORCPT ); Fri, 19 Feb 2016 10:00:32 -0500 Date: Fri, 19 Feb 2016 10:00:27 -0500 From: "Theodore Ts'o" To: Rasmus Villemoes Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] vfs: make sure struct filename->iname is word-aligned Message-ID: <20160219150027.GD20458@thunk.org> Mail-Followup-To: Theodore Ts'o , Rasmus Villemoes , Al Viro , Jeff Layton , "J. Bruce Fields" , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <1455662966-7977-1-git-send-email-linux@rasmusvillemoes.dk> <20160216225738.GD17997@ZenIV.linux.org.uk> <878u2heq4y.fsf@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878u2heq4y.fsf@rasmusvillemoes.dk> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 09:10:21PM +0100, Rasmus Villemoes wrote: > > Sure, that would work as well. I don't really care how ->iname is pushed > out to offset 32, but I'd like to know if it's worth it. Do you have access to one of these platforms where unaligned access is really painful? The usual thing is to benchmark something like "git stat" which has to stat every single file in a repository's working directory. If you can't see it there, it seems unlikely you'd see it anywhere else, yes? - Ted