From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948790AbcBSPGh (ORCPT ); Fri, 19 Feb 2016 10:06:37 -0500 Received: from mga02.intel.com ([134.134.136.20]:54360 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948016AbcBSPGg (ORCPT ); Fri, 19 Feb 2016 10:06:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,470,1449561600"; d="scan'208";a="50923648" Date: Fri, 19 Feb 2016 17:06:06 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource Message-ID: <20160219150606.GB7474@intel.com> References: <1455668874-13261-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160217045219.GA26086@obsidianresearch.com> <20160217093623.GA9831@intel.com> <20160217142016.GA6951@intel.com> <20160218173140.GA5899@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218173140.GA5899@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 10:31:40AM -0700, Jason Gunthorpe wrote: > On Wed, Feb 17, 2016 at 04:20:16PM +0200, Jarkko Sakkinen wrote: > > Maybe for the release the safest bet would be anyway explicitly not > > use the name field? That's the safest bet given the release time > > frame. > > nulling it in the acpi paths of tis and crb, if you know those are broken > seems good for a rc. > > I haven't looked at what other options there are, I suspect it needs > strdup due to how the drivers are working with acpi.. Can you quickly check the two top-most patches: https://github.com/jsakkine/linux-tpmdd/commits/master This is for 4.5 release. > Jason /Jarkko