From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949230AbcBSPIx (ORCPT ); Fri, 19 Feb 2016 10:08:53 -0500 Received: from mail.kernel.org ([198.145.29.136]:58224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1949189AbcBSPIv (ORCPT ); Fri, 19 Feb 2016 10:08:51 -0500 Date: Fri, 19 Feb 2016 12:08:47 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: Alexei Starovoitov , Brendan Gregg , Adrian Hunter , Cody P Schafer , "David S. Miller" , He Kuang , =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau , Jiri Olsa , Kirill Smelkov , Li Zefan , Masami Hiramatsu , Namhyung Kim , Peter Zijlstra , pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/55] perf tools: Enable config raw and numeric events Message-ID: <20160219150847.GE16141@kernel.org> References: <1455882283-79592-1-git-send-email-wangnan0@huawei.com> <1455882283-79592-13-git-send-email-wangnan0@huawei.com> <20160219141405.GC16141@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160219141405.GC16141@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 19, 2016 at 11:44:00AM +0000, Wang Nan escreveu: > This patch allows setting config terms for raw and numeric events. > For example: > > # perf stat -e cycles/name=cyc/ ls > ... > 1821108 cyc > ... > > # perf stat -e r6530160/name=event/ ls > ... > 1103195 event > ... > > # perf record -e cycles -e 4:0x6530160/name=evtx,call-graph=fp/ -a sleep 1 > ... > # perf report --stdio Nice stuff, but I'm investigating now why I'm getting this: [acme@jouet linux]$ make O=/tmp/build/perf -C tools/perf install-bin make: Entering directory '/home/acme/git/linux/tools/perf' BUILD: Doing 'make -j4' parallel build BISON /tmp/build/perf/util/parse-events-bison.c util/parse-events.y:436.23-38: error: symbol opt_event_config is used, but is not defined as a token and has no rules PE_VALUE ':' PE_VALUE opt_event_config ^^^^^^^^^^^^^^^^ util/parse-events.y:442.68-69: error: $4 of ‘event_legacy_numeric’ has no declared type ABORT_ON(parse_events_add_numeric(data, list, (u32)$1, $3, $4)); ^^ util/parse-events.y:443.36-37: error: $4 of ‘event_legacy_numeric’ has no declared type parse_events_terms__delete($4); ^^ util/parse-events.y:454.74-75: error: $2 of ‘event_legacy_raw’ has no declared type ABORT_ON(parse_events_add_numeric(data, list, PERF_TYPE_RAW, $1, $2)); ^^ util/parse-events.y:455.36-37: error: $2 of ‘event_legacy_raw’ has no declared type parse_events_terms__delete($2); ^^ util/Build:122: recipe for target '/tmp/build/perf/util/parse-events-bison.c' failed make[3]: *** [/tmp/build/perf/util/parse-events-bison.c] Error 1 /home/acme/git/linux/tools/build/Makefile.build:116: recipe for target 'util' failed make[2]: *** [util] Error 2 Makefile.perf:434: recipe for target '/tmp/build/perf/libperf-in.o' failed make[1]: *** [/tmp/build/perf/libperf-in.o] Error 2 make[1]: *** Waiting for unfinished jobs.... Makefile:108: recipe for target 'install-bin' failed make: *** [install-bin] Error 2 make: Leaving directory '/home/acme/git/linux/tools/perf' [acme@jouet linux]$