From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S2993288AbcBSPPh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 19 Feb 2016 10:15:37 -0500
Received: from mail.kernel.org ([198.145.29.136]:58788 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932160AbcBSPPg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 19 Feb 2016 10:15:36 -0500
Date: Fri, 19 Feb 2016 12:15:33 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Cody P Schafer <dev@codyps.com>,
        "David S. Miller" <davem@davemloft.net>, He Kuang <hekuang@huawei.com>,
        =?iso-8859-1?Q?J=E9r=E9mie?= Galarneau 
	<jeremie.galarneau@efficios.com>,
        Jiri Olsa <jolsa@kernel.org>, Kirill Smelkov <kirr@nexedi.com>,
        Li Zefan <lizefan@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, pi3orama@163.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/55] perf tools: Enable config raw and numeric events
Message-ID: <20160219151533.GA12977@kernel.org>
References: <1455882283-79592-1-git-send-email-wangnan0@huawei.com>
 <1455882283-79592-13-git-send-email-wangnan0@huawei.com>
 <20160219141405.GC16141@kernel.org>
 <20160219150847.GE16141@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160219150847.GE16141@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Feb 19, 2016 at 12:08:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Feb 19, 2016 at 11:44:00AM +0000, Wang Nan escreveu:
> > This patch allows setting config terms for raw and numeric events.
> > For example:
> > 
> >  # perf stat -e cycles/name=cyc/ ls
> >  ...
> >  1821108      cyc
> >  ...
> > 
> >  # perf stat -e r6530160/name=event/ ls
> >  ...
> >  1103195      event
> >  ...
> > 
> >  # perf record -e cycles -e 4:0x6530160/name=evtx,call-graph=fp/ -a sleep 1
> >  ...
> >  # perf report --stdio
> 
> Nice stuff, but I'm investigating now why I'm getting this:
> 
>   [acme@jouet linux]$ make O=/tmp/build/perf -C tools/perf install-bin
>   make: Entering directory '/home/acme/git/linux/tools/perf'
>     BUILD:   Doing 'make -j4' parallel build
>     BISON    /tmp/build/perf/util/parse-events-bison.c
>   util/parse-events.y:436.23-38: error: symbol opt_event_config is used, but is not defined as a token and has no rules
>    PE_VALUE ':' PE_VALUE opt_event_config
>                          ^^^^^^^^^^^^^^^^

Ok, this is because I deferred the patch that introduces this
'opt_event_config' thing, that is buried in a BPF patch, when it
could've probably have stood out in a separate patch, trying that now.

- Arnaldo