From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948900AbcBSPGq (ORCPT ); Fri, 19 Feb 2016 10:06:46 -0500 Received: from down.free-electrons.com ([37.187.137.238]:49396 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1948016AbcBSPGo (ORCPT ); Fri, 19 Feb 2016 10:06:44 -0500 Date: Fri, 19 Feb 2016 16:06:32 +0100 From: Thomas Petazzoni To: Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip/gic: Return IRQ_SET_MASK_OK_DONE in the set_affinity method Message-ID: <20160219160632.1947d1a2@free-electrons.com> In-Reply-To: <1455894029-17270-1-git-send-email-marc.zyngier@arm.com> References: <1455894029-17270-1-git-send-email-marc.zyngier@arm.com> Organization: Free Electrons X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marc, On Fri, 19 Feb 2016 15:00:29 +0000, Marc Zyngier wrote: > Moving an SPI around doesn't require any extra work from the rest > of the stack, and specially not for MSI-generated SPIs. > > It is then worth returning IRQ_SET_MASK_OK_DONE instead of > IRQ_SET_MASK_OK, and simplify the other irqchips that rely on > this behaviour (GICv2m and Marvell's ODMI controller). > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v2m.c | 14 +------------- > drivers/irqchip/irq-gic.c | 2 +- > drivers/irqchip/irq-mvebu-odmi.c | 14 +------------- > 3 files changed, 3 insertions(+), 27 deletions(-) For the irq-mvebu-odmi part: Acked-by: Thomas Petazzoni Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com