From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947372AbcBSQsy (ORCPT ); Fri, 19 Feb 2016 11:48:54 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:35224 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427393AbcBSQsv (ORCPT ); Fri, 19 Feb 2016 11:48:51 -0500 Date: Fri, 19 Feb 2016 16:48:44 +0000 From: Russell King - ARM Linux To: Stephen Boyd Cc: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: gpio: Really allow an optional clock= DT property Message-ID: <20160219164844.GA19428@n2100.arm.linux.org.uk> References: <20160219030731.GS4847@codeaurora.org> <1455851525-18972-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455851525-18972-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 07:12:05PM -0800, Stephen Boyd wrote: > We mis-merged the original patch from Russell here and so the > patch went almost all the way, except that we still failed to > probe when there wasn't a clocks property in the DT node. Allow > that case by making a negative value from > of_clk_get_parent_count() into "no parents", like the original > patch did. NAK. I'm not testing this patch, when I've already spent more than enough time (a) developing the original patch and testing that, and (b) re-diagnosing what's going wrong, and re-fixing the fuck up, and testing that fix. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.