From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428135AbcBSREJ (ORCPT ); Fri, 19 Feb 2016 12:04:09 -0500 Received: from muru.com ([72.249.23.125]:46675 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161125AbcBSREH (ORCPT ); Fri, 19 Feb 2016 12:04:07 -0500 Date: Fri, 19 Feb 2016 09:04:05 -0800 From: Tony Lindgren To: Peter Ujfalusi Cc: hs@denx.de, j-keerthy@ti.com, broonie@kernel.org, robh@kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] Revert "regulator: tps65217: remove tps65217.dtsi file" Message-ID: <20160219170404.GH21202@atomide.com> References: <1455891139-6139-1-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455891139-6139-1-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Ujfalusi [160219 06:14]: > This reverts commit 8e6ebfaa9b384088002baa10f7534efa73a0794e. > > Without the patch reverted regulators will not work. This prevents > MMC to be working for example so the boards can not boot to > MMC rootfs. > > Tested it on beaglebone white and bisect also points to the > reverted commit. > The issue can be also fixed by adding "regulator-compatible =" to all board > dts file for the regulators. > > Signed-off-by: Peter Ujfalusi > --- > Hi, > > I have noticed that bbw did not find the MMC with linux-next, but it turns out > that even 4.5-rc4 is behaving the same way. > I have run bisect and with this revert patch I can boot up fine. > To be honest I don't know why the tps65217.dtsi has been deleted in the first > place. I think initially the only real issue was the naming. The tps65217.dtsi file should be just renamed to tps65217-am335x.dtsi to make it clear that this configuration is commonly used for most am335x boards. I'll apply this revert into omap-for-v4.5/fixes as it fixes a regression. Thanks, Tony