From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource
Date: Fri, 19 Feb 2016 10:44:34 -0700 [thread overview]
Message-ID: <20160219174434.GA15013@obsidianresearch.com> (raw)
In-Reply-To: <20160219150606.GB7474@intel.com>
On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote:
> Can you quickly check the two top-most patches:
>
> https://github.com/jsakkine/linux-tpmdd/commits/master
Drop the change to crb_map_res, the memset is not needed.
The shutdown change is probably OK for a rc fix, but it is still wrong.
The shutdown has to be done inside the code after the core has removed
all access to the tpm but before it has torn down so much that the
driver doesn't work anymore.
Jason
next prev parent reply other threads:[~2016-02-19 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 0:27 [PATCH] tpm_crb: fix bad name pointer usage with struct resource Jarkko Sakkinen
2016-02-17 4:52 ` [tpmdd-devel] " Jason Gunthorpe
2016-02-17 9:36 ` Jarkko Sakkinen
2016-02-17 14:20 ` Jarkko Sakkinen
2016-02-18 17:31 ` Jason Gunthorpe
2016-02-19 15:06 ` Jarkko Sakkinen
2016-02-19 17:44 ` Jason Gunthorpe [this message]
2016-02-20 8:04 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219174434.GA15013@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).