From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949396AbcBSUQU (ORCPT ); Fri, 19 Feb 2016 15:16:20 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33272 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1949378AbcBSUQS convert rfc822-to-8bit (ORCPT ); Fri, 19 Feb 2016 15:16:18 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Joshua Henderson , linux-kernel@vger.kernel.org From: Michael Turquette In-Reply-To: <1455899179-14097-3-git-send-email-joshua.henderson@microchip.com> Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, "Purna Chandra Mandal" , "Joshua Henderson" , "Stephen Boyd" , linux-clk@vger.kernel.org References: <1455899179-14097-1-git-send-email-joshua.henderson@microchip.com> <1455899179-14097-3-git-send-email-joshua.henderson@microchip.com> Message-ID: <20160219201615.2278.2909@quark.deferred.io> User-Agent: alot/0.3.6 Subject: Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver Date: Fri, 19 Feb 2016 12:16:15 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Joshua Henderson (2016-02-19 08:25:35) > +const struct clk_ops pic32_roclk_ops = { > + .enable = roclk_enable, > + .disable = roclk_disable, > + .is_enabled = roclk_is_enabled, > + .get_parent = roclk_get_parent, > + .set_parent = roclk_set_parent, > + .determine_rate = roclk_determine_rate, > + .recalc_rate = roclk_recalc_rate, > + .round_rate = roclk_round_rate, > + .set_rate_and_parent = roclk_set_rate_and_parent, > + .set_rate = roclk_set_rate, > + .init = roclk_init, > +}; You can remove .round_rate and only use .determine_rate. ... > +CLK_OF_DECLARE(pic32mzda_clk, "microchip,pic32mzda-clk", pic32mzda_clock_init); Can you make this a platform_driver instead of using CLK_OF_DECLARE? I asked this in v6 but there was no response. Regards, Mike > -- > 1.7.9.5 >