[PATCH] staging: xgifb: Fix comment style

[PATCH] staging: xgifb: Fix comment style

[Bo YU]

Fix comments to use trailing */ on separate lines.

Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
  drivers/staging/xgifb/vb_init.c |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539b..c7f02c7 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -699,11 +699,11 @@ static void XGINew_CheckChannel(struct
xgi_hw_device_info *HwDeviceExtension,
  break;
  case XG42:
  /*
- XG42 SR14 D[3] Reserve
- D[2] = 1, Dual Channel
- = 0, Single Channel
-
- It's Different from Other XG40 Series.
+ * XG42 SR14 D[3] Reserve
+ * D[2] = 1, Dual Channel
+ * = 0, Single Channel
+ *
+ * It's Different from Other XG40 Series.
  */
  if (XGINew_CheckFrequence(pVBInfo) == 1) { /* DDRII, DDR2x */
  pVBInfo->ram_bus = 32; /* 32 bits */
--
1.7.10.4


--
Best Regards

Re: [PATCH] staging: xgifb: Fix comment style

[Kroah-Hartman]

On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
> Fix comments to use trailing */ on separate lines.
> 
> Signed-off-by: YU BO <tsu.yubo@gmail.com>
> ---
>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Patch doesn't apply :(

Re: [PATCH] staging: xgifb: Fix comment style

[Bo YU]

Hello,

On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:
>On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
>> Fix comments to use trailing */ on separate lines.
>>
>> Signed-off-by: YU BO <tsu.yubo@gmail.com>
>> ---
>>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>
>Patch doesn't apply :(
I don't know that whether i am doing wrong something with git.
Because when i run `git am the-codingfixed-patch` ,it reports error.
But run `patch -p1 the-codingfixed-patch` it is ok.

Perhaps i am wrong with others.

Could you tell me a little hit?

Sorry for the noisy.:)
--
Best Regards

Re: [PATCH] staging: xgifb: Fix comment style

[Kroah-Hartman]

On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote:
> Hello,
> 
> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:
> >On Wed, Feb 17, 2016 at 02:53:34PM +0800, Bo YU wrote:
> >> Fix comments to use trailing */ on separate lines.
> >>
> >> Signed-off-by: YU BO <tsu.yubo@gmail.com>
> >> ---
> >>   drivers/staging/xgifb/vb_init.c |   10 +++++-----
> >>   1 file changed, 5 insertions(+), 5 deletions(-)
> >
> >Patch doesn't apply :(
> I don't know that whether i am doing wrong something with git.
> Because when i run `git am the-codingfixed-patch` ,it reports error.

Yes, that is the problem, please work on fixing that.  I don't have the
time to determine exactly what the error is, sorry.

greg k-h

Re: [PATCH] staging: xgifb: Fix comment style

[Bo YU]

Hi,
On Sun, Feb 21, 2016 at 11:33:48AM -0800, Kroah-Hartman wrote:
>On Sun, Feb 21, 2016 at 04:59:17PM +0800, Bo YU wrote:
>> Hello,
>>
>> On Sat, Feb 20, 2016 at 03:38:15PM -0800, Kroah-Hartman wrote:

>> >Patch doesn't apply :(
>> I don't know that whether i am doing wrong something with git.
>> Because when i run `git am the-codingfixed-patch` ,it reports error.
>
>Yes, that is the problem, please work on fixing that.  I don't have the
>time to determine exactly what the error is, sorry.
>
I will fix that :)
Thanks a lot for your patience and help.
>greg k-h

--
Best Regards

[PATCH] staging: xgifb: Fix comment style

[YU Bo]

Fix comments to use trailing */ on separste lines.

Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
 drivers/staging/xgifb/vb_init.c    |    3 ++-
 drivers/staging/xgifb/vb_setmode.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539bc6faf..572487388e81 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -355,7 +355,8 @@ static void XGINew_DDR2_DefaultRegister(
 	unsigned long P3d4 = Port, P3c4 = Port - 0x10;

 	/* keep following setting sequence, each setting in
-	 * the same reg insert idle */
+	 * the same reg insert idle
+	 */
 	xgifb_reg_set(P3d4, 0x82, 0x77);
 	xgifb_reg_set(P3d4, 0x86, 0x00);
 	xgifb_reg_get(P3d4, 0x86); /* Insert read command for delay */
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index f97c77d88173..240d4257bc2f 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1992,7 +1992,8 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
 		}

 		/* LCD+TV can't support in slave mode
-		 * (Force LCDA+TV->LCDB) */
+		 * (Force LCDA+TV->LCDB)
+		 */
 		if ((tempbx & SetInSlaveMode) && (tempbx & XGI_SetCRT2ToLCDA)) {
 			tempbx ^= (SetCRT2ToLCD | XGI_SetCRT2ToLCDA |
 				   SetCRT2ToDualEdge);
--
1.7.10.4

Re: [PATCH] staging: xgifb: Fix comment style

[Kroah-Hartman]

On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote:
> Fix comments to use trailing */ on separste lines.
> 
> Signed-off-by: YU BO <tsu.yubo@gmail.com>
> ---
> drivers/staging/xgifb/vb_init.c    |    3 ++-
> drivers/staging/xgifb/vb_setmode.c |    3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)

You sent me 2 different patches with the identical subject: line, which
I can't accept.  Please fix them up and send a patch series, with unique
subjects.

thanks,

greg k-h

Re: [PATCH] staging: xgifb: Fix comment style

[Bo Yu]

On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote:
hi,
>On Sat, Mar 12, 2016 at 03:40:35AM -0500, YU Bo wrote:
>> Fix comments to use trailing */ on separste lines.
>>
>> Signed-off-by: YU BO <tsu.yubo@gmail.com>
>> ---
>> drivers/staging/xgifb/vb_init.c    |    3 ++-
>> drivers/staging/xgifb/vb_setmode.c |    3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>You sent me 2 different patches with the identical subject: line, which
>I can't accept.  Please fix them up and send a patch series, with unique
>subjects.
yes, you are right:) I will fix them up and resend a patch series.
Sorry for the noise.
Thanks.
>
>thanks,
>
>greg k-h

[PATCH] staging: xgifb: Fix comment style

[YU Bo]

Fix comments to use * on subsequent lines.

Signed-off-by: YU BO <tsu.yubo@gmail.com>
---
 drivers/staging/xgifb/vb_init.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 26b539bc6faf..c7f02c7db4a2 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -699,11 +699,11 @@ static void XGINew_CheckChannel(struct xgi_hw_device_info *HwDeviceExtension,
 		break;
 	case XG42:
 		/*
-		 XG42 SR14 D[3] Reserve
-		 D[2] = 1, Dual Channel
-		 = 0, Single Channel
-
-		 It's Different from Other XG40 Series.
+		 * XG42 SR14 D[3] Reserve
+		 * D[2] = 1, Dual Channel
+		 * = 0, Single Channel
+		 *
+		 * It's Different from Other XG40 Series.
 		 */
 		if (XGINew_CheckFrequence(pVBInfo) == 1) { /* DDRII, DDR2x */
 			pVBInfo->ram_bus = 32; /* 32 bits */
--
1.7.10.4