From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752078AbcBUSlW (ORCPT ); Sun, 21 Feb 2016 13:41:22 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35763 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbcBUSlT (ORCPT ); Sun, 21 Feb 2016 13:41:19 -0500 Date: Sun, 21 Feb 2016 14:01:28 +0900 From: Sergey Senozhatsky To: Mimi Zohar Cc: Sergey Senozhatsky , Ming Lei , Greg Kroah-Hartman , Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware() Message-ID: <20160221050128.GA563@swordfish> References: <1455959650-2571-1-git-send-email-sergey.senozhatsky@gmail.com> <1455960148-4781-1-git-send-email-sergey.senozhatsky@gmail.com> <1456027178.2906.196.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456027178.2906.196.camel@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On (02/20/16 22:59), Mimi Zohar wrote: > On Sat, 2016-02-20 at 18:22 +0900, Sergey Senozhatsky wrote: > > Set firmware_buf->size in fw_get_filesystem_firmware() after > > successful kernel_read_file_from_path(), otherwise assign_firmware_buf() > > fails. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/base/firmware_class.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > > index b8bc846..7cf41a5 100644 > > --- a/drivers/base/firmware_class.c > > +++ b/drivers/base/firmware_class.c > > @@ -335,6 +335,7 @@ static int fw_get_filesystem_firmware(struct device *device, > > } > > dev_dbg(device, "direct-loading %s\n", > > buf->fw_id); > > + buf->size = size; > > fw_finish_direct_load(device, buf); > > break; > > } > > Thanks, Sergey. > > Somehow this was dropped in v4. sure, no prob. if there is a way to fold this small fix into the original patch, then I wouldn't mind at all to go with this option. The other thing is that, the dmesg output has changed, and now it keeps the log of unsuccessful ucode accesses from ->ucode_api_max to ->ucode_api_min: [ 1.236866] Unable to open file: /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode (-2) [ 1.236874] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode failed with error -2 [ 1.236889] Unable to open file: /lib/firmware/updates/iwlwifi-7260-17.ucode (-2) [ 1.236894] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/iwlwifi-7260-17.ucode failed with error -2 [ 1.237064] Unable to open file: /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode (-2) [ 1.237073] iwlwifi 0000:02:00.0: loading /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode failed with error -2 [ 1.237094] Unable to open file: /lib/firmware/iwlwifi-7260-17.ucode (-2) [ 1.237099] iwlwifi 0000:02:00.0: loading /lib/firmware/iwlwifi-7260-17.ucode failed with error -2 [ 1.237106] iwlwifi 0000:02:00.0: Direct firmware load for iwlwifi-7260-17.ucode failed with error -2 [ 1.237190] Unable to open file: /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode (-2) [ 1.237195] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode failed with error -2 [ 1.237201] Unable to open file: /lib/firmware/updates/iwlwifi-7260-16.ucode (-2) [ 1.237204] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/iwlwifi-7260-16.ucode failed with error -2 [ 1.237217] Unable to open file: /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode (-2) [ 1.237221] iwlwifi 0000:02:00.0: loading /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode failed with error -2 is this intentional? is there any reason to give this info back to user or this is just a small regression? -ss