From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752723AbcBUR2R (ORCPT ); Sun, 21 Feb 2016 12:28:17 -0500 Received: from down.free-electrons.com ([37.187.137.238]:45261 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751021AbcBUR2Q (ORCPT ); Sun, 21 Feb 2016 12:28:16 -0500 Date: Sun, 21 Feb 2016 09:18:30 -0800 From: Maxime Ripard To: Henry Paulissen Cc: linux-sunxi@googlegroups.com, Linus Walleij , Chen-Yu Tsai , Patrice Chotard , Jean-Christophe PLAGNIOL-VILLARD , Maxime Coquelin , Fabian Frederick , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Fix sun7i pin assignment for IRQ's Message-ID: <20160221171830.GD19169@lukather> References: <1456060845-20692-1-git-send-email-henry@nitronetworks.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZJcv+A0YCCLh2VIg" Content-Disposition: inline In-Reply-To: <1456060845-20692-1-git-send-email-henry@nitronetworks.nl> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZJcv+A0YCCLh2VIg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Feb 21, 2016 at 02:20:41PM +0100, Henry Paulissen wrote: > After testing IRQ pins we found some bugs in the pinctrl declaration. Your commit log is going to need some work. Which bugs? What tests did you make? Why are you making these changes while the datasheet says otherwise? > Signed-off-by: Henry Paulissen > --- >=20 > Changes in v2: > After some more testing we found irq on PI pins. > they where on mux6 so this is included in my patch. >=20 > Also included is a warning for PI17, this pin was not working > on apritzel his bPI and he thinks it might be correlated to > GIC and IRQ 29. >=20 > Changes in v3: > Changed name from nickname to realname in email and SoB. > --- > drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c b/drivers/pinctrl/= sunxi/pinctrl-sun7i-a20.c > index cf1ce0c..0fe173e 100644 > --- a/drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c > +++ b/drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c > @@ -344,25 +344,21 @@ static const struct sunxi_desc_pin sun7i_a20_pins[]= =3D { > SUNXI_FUNCTION(0x1, "gpio_out"), > SUNXI_FUNCTION(0x2, "nand0"), /* NCE4 */ > SUNXI_FUNCTION(0x3, "spi2"), /* CS0 */ > - SUNXI_FUNCTION_IRQ(0x6, 12)), /* EINT12 */ Have you tried to compile it? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ZJcv+A0YCCLh2VIg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWyfFmAAoJEBx+YmzsjxAgsWcQAJNLXxlSQ7txvr8hnM73nlP/ qaQzyAjwdVxn7p5SUtpxF8wUIMXEsbaE+HW8OZWNQ1krfpXzcQtIw0EZai4TgtIP ZwXeQbOGfsSuEhmZVnds2di3OYn9jnkHVFxMTYu/ysrXwOubRrW6P5mRu2bCt5G7 UJzM34zf+TGIcXoJhpDGtcCU27vBKvGntyc6k37XuWIj0O+W+gtJpGEK8NQJDzpR INplUGg/BTeI/ZAqCToR1xzDff2j6zsgUUZPQC70AAQzNWNE0VvthU0+mkD7/OaD sqtiV0YqXIDRe9G7pkxQathwn6lAUMbcNSsV3upFJVnkVVgx3HFun4GIl4v1+qET 0scSEGKnLxwUqoIP+Ls2D+L3Zq1NIscH8E7AD/zQpSNr7TGZ4DFiebmfziJ9c6pv gMma3OFUUTbTfZ46Z/tftjzuhA1rZO8IGm5i9AmHpyFUVZnWSCRMcf8rZEAgrQlC Ow2bZG+pMCqYYw9liObZlv2bbCaTvkn9q/yqw/ise6wuUeebcZtigY5pBf+0xexg MpdspaONrjKMaLaL+SH7H4n1VdYBkpF0P2l9nw6BKPGfixqa5TOICwFmNzS9SOYf EpN9b5vaBoMqQ6voyF6Pd+tOMrBBEaG9x+lFBAzj0wAIRe8f0443FavKv2lsN9I+ XwnX+mm0s51UQpeof05y =wyCi -----END PGP SIGNATURE----- --ZJcv+A0YCCLh2VIg--