From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbcBVEld (ORCPT ); Sun, 21 Feb 2016 23:41:33 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:46560 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752539AbcBVElb (ORCPT ); Sun, 21 Feb 2016 23:41:31 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Mon, 22 Feb 2016 13:41:45 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Sergey Senozhatsky , Andrew Morton , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH v2 3/3] mm/zsmalloc: increase ZS_MAX_PAGES_PER_ZSPAGE Message-ID: <20160222044145.GE27829@bbox> References: <1456061274-20059-1-git-send-email-sergey.senozhatsky@gmail.com> <1456061274-20059-4-git-send-email-sergey.senozhatsky@gmail.com> <20160222002515.GB21710@bbox> <20160222004758.GB4958@swordfish> <20160222013442.GB27829@bbox> <20160222020113.GB488@swordfish> <20160222023432.GC27829@bbox> <20160222035954.GC11961@swordfish> MIME-Version: 1.0 In-Reply-To: <20160222035954.GC11961@swordfish> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/02/22 13:41:29, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/02/22 13:41:29, Serialize complete at 2016/02/22 13:41:29 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 12:59:54PM +0900, Sergey Senozhatsky wrote: > On (02/22/16 11:34), Minchan Kim wrote: > [..] > > > I'll take a look at dynamic class page addition. > > > > Thanks, Sergey. > > > > Just a note: > > > > I am preparing zsmalloc migration now and almost done so I hope > > I can send it within two weeks. In there, I changed a lot of > > things in zsmalloc, page chaining, struct page fields usecases > > and locking scheme and so on. The zsmalloc fragment/migration > > is really painful now so we should solve it first so I hope > > you help to review that and let's go further dynamic chaining > > after that, please. :) > > oh, sure. > > so let's keep dynamic page allocation out of sight for now. > I'll do more tests with the increase ORDER and if it's OK then > hopefully we can just merge it, it's quite simple and shouldn't > interfere with any of the changes you are about to introduce. Thanks. And as another idea, we could try fallback approach that we couldn't meet nr_pages to minimize wastage so let's fallback to order-0 page like as-is. It will enhance, at least than now with small-amount of code compared to dynmaic page allocation.