From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754438AbcBVMkv (ORCPT ); Mon, 22 Feb 2016 07:40:51 -0500 Received: from mail-by2on0067.outbound.protection.outlook.com ([207.46.100.67]:7333 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754210AbcBVMkt (ORCPT ); Mon, 22 Feb 2016 07:40:49 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Mon, 22 Feb 2016 13:40:34 +0100 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v4 3/5] arm64: dts: Add Cavium ThunderX specific PMU Message-ID: <20160222124034.GA766@hardcore> References: <20160218173248.GD16883@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160218173248.GD16883@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.66.101.161] X-ClientProxiedBy: AM3PR07CA0049.eurprd07.prod.outlook.com (10.141.45.177) To BLUPR0701MB753.namprd07.prod.outlook.com (10.141.252.19) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB753;2:p/k+8jtc6MgB1FcFxSw8/GRjDn73Oriq3PXzp0JjNnWzjNX4BEWgfGmhh7ALOoJCaeJcKYG2DmPwnYYEUIdkpd3ZeZLKPlhTpBRT2nIiBnogSQHXvOp16bYb0VW5Ev1Xws2x7e5QlqdpfGVuCfEgYA==;3:QX4GIyPNe+4PIe3mhCuCWxbxH0ekkXZ5eDW802Z6Xs/dbqhiXs/0jxpkgODA/+jg4iUIzQp/k7n1aJ75OjobKbhAj2DobSmJAUwD0qQlPQ4hWAUTuvy7F7F3JfH26uyC;25:uNO+HTlJIm/OuL2JmVlg4s+li1J68/ByRXbQ3sHTXuvawKE/zqvy6kLK0zbZDDrWE/uxM+8Qu9GN0njsFfeuxXHKw5EvWJHUMHDU6ifXdkI3PsLAwthljAKVTo4GE+/NJPZWEyYe3Hng6E6okcJYOXJmglQmUQefM0Un4Gsw8jLeB9HGP/Ah2wK7Xzv3Tgbht4JJ/flTIfRmhg1AwlUvsx5JTwPL8IucW1bWhGN6YGvs7o+dxoktKGxDGhcE+OyKCV+cvtrzeAa78FxF90JPO69SCnw2DdYkVSZVne1/2xdXfxwtHTE+drtQFOjgzgWo6VO39qptnCcjDM0YeT4HqTL+1LlnMN19C8LIE7wjf2I= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB753; X-MS-Office365-Filtering-Correlation-Id: f26efddb-1db4-451e-abde-08d33b856363 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB753;20:4cKh96dLTTRvWbh/aCoj9xbfJz9cLSMkX7Hnso7tLGk+K+JpGwrzSBN3jxqS8Vi8zubuqddihXF/3ydbL3BsIK51gTAJFKYAqyDb2oq2epYYYIu2t9vkOF9hFgoCntjdMdAGMfu9SuFuyQHYRJoYqpCRs2aZydHWdd4JhzZjJ8fir6bibIhGHzwW+JG6JqxHXTrYQpUK0147L6C8Z8L04j5pJTlvmE6wD7+uLuXWy2A3ocW28VzWJuuvAWdx9ck78QMK1J8t9wU1tXtY9W6eXLM/RdudlCNqPqyDhnqaXzn7n5fHzT3T1ZFsELSjZQDbyhgNmDxhC6rWDzHJoUaTB4n1MP6f5AxhAQnHKZbffFu6NFj7+hWUuR5EyxeHn9LOVX35ywBhbsa2hw5plerguPZMNa+r3IrCFluawCmE7TO6wujadqYG6q/ItnvrDETHMUugfr1dW1tuG1fxp2vLyjrsSBX7g61Ieq39EGYuQCcHsf3tlvGhrvia1HEh1S6je7ClBrTF4hvkBLN7PpiFDsbZ0/8T6vESy9LyrsiPamZ5xB5Kn2GWdaBFUp45Z1SGXXJ/0GtpthntH5JDz5cWRz1U77NA+YmpJwAp+ZljGt4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BLUPR0701MB753;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB753; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB753;4:ohaVgucZldBcat+MAgHNH0ttb+hnobDn6q32XWihtWGlbyQ9ELkTfFoInNK+CTo5szVB37/BOPAxReqtrgaefijEPURse4TfszspXOYq6+oyOHb0lRY6AvzDATzP9ePdArfpSuxXhoTh+gC1WgH7aMrJTfB/QkkMpf5+JnBW55e4TsVWxOHqmfCAGMCOhdjYFgYCRb4gqvtz2g3FVArFpWS6Qt07bibvMEe8yDl+NOj6sySrAF8w3G13wT2QSDtgiVOb/Ro+JSXobm8FHDCKhxux39jMxFOb0MgzwRxL1NPVKyx3vt0DbWPIG7fCyPQhYFdN4LaiYRO6QgnLG9lCjdAYaCYh4K3wyft7AXodjfKL0IZYAwZSo4e5FJ3Pd4Uj X-Forefront-PRVS: 0860FE717F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(87976001)(42186005)(3846002)(50986999)(76176999)(54356999)(110136002)(5001960100002)(189998001)(586003)(5008740100001)(5004730100002)(2906002)(66066001)(47776003)(1076002)(1096002)(4326007)(33716001)(6116002)(50466002)(23726003)(83506001)(92566002)(2950100001)(86362001)(40100003)(33656002)(122386002)(19580395003)(19580405001)(46406003)(77096005)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB753;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0701MB753;23:Md+JhnbrFBzbrXgQMArIxV7T5zMfrRjpGvExdPkF?= =?us-ascii?Q?JemJhRawCEez7wMWp861D6QjFwSw/U+Kye3nh94HNEKNkPRqNKCaB6pc2UuG?= =?us-ascii?Q?9/sct7S9NwjFIQjs3c121jbbLrLVQTSYnKUjGWEjyUQaRSP+Ghbhaf4gVL3V?= =?us-ascii?Q?BR79F6HSPIqFnvCxK52iTxf6ayQcBM7aziebEefJwixDF5arDd/t6przmkWN?= =?us-ascii?Q?xng1QSMILKxe7QHIwmfEOC6/17muC5/8oMdSCj9fAlUKSGxzHamNDzJ2T5U+?= =?us-ascii?Q?BT1CxF0Tb6JJ1SCBhPyp9TVTrzciEtQZgyV60/C/+qofvxboA1en/mVCKjjI?= =?us-ascii?Q?VaNHFk5OU/pq+o4t059YLzoyWGrY0OscgZqp30TKiXXowpvLQBWTivqtrLfT?= =?us-ascii?Q?0lxQE9wPHFqTXEBxc2lB/ZO+2kuvlGxDxME1yOIm4wWwAUSEoqqII8cL2O/l?= =?us-ascii?Q?9X5giJxFWRUjBgwAjmUQGkubqSQ2E/AtTgkpnLsVlOB1rv1XByXJPo2Wq9gH?= =?us-ascii?Q?vtTfAGQrA05x7fO+msHF3sfb88AlZ+nF1m3Hf8gZstp4sOo9SxXahmqd/SEP?= =?us-ascii?Q?LkLUKy2j10M47qkWrEwYb8mlPJqmZTzL2f/yIrDn++8GofyRpOu0oef9sE02?= =?us-ascii?Q?x6aHQMZhHAXkmYIGIzltj0N7AOV2a7/f9jWVfIN5bxe1lgy3n7jl9ImmmTOc?= =?us-ascii?Q?tgeZ9iOtE81D9549TUDCEiJqhb6aVRnWvO9JJKkjROBzXlgE53HxaHNoF88Q?= =?us-ascii?Q?XqoT4HCnX4AgIQOsGhEaLi1WBokCuuj7+gVFLI2/g/isd9PBP23G/Por9Ym8?= =?us-ascii?Q?jCC9BFtxhP2T0ih8nddZUVefeZ1cjE0OjvkNr2dTSjXqQq6xZcRz1UqoejYl?= =?us-ascii?Q?lcYqDvM65wvXVsVRUTkcYmra8/uyaj6JJITMANj/4y1B9Yx0li5RSD/I1+bA?= =?us-ascii?Q?ubbAApoLWj5e6Kd/E2h1HfqU2bIUWCS1cUHLD/1v1XeQ14uIwZ20CfvJeUpW?= =?us-ascii?Q?25GJCD6GTO6abPNhGa7YbK7V?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB753;5:/0QlRV0vE/Lu1xkqlk7Xnr7rlbH3i4XBCcPSKGsdtPBKF0NKQC/OmL+FzdBUGp7kabuR17jKs1olX2ITw5Q3oVTeKZ3lG5k+FEWt8gf11uT+uu09cLf95pKvqRhckpDAdzF+H2DW4wayJicjgftg5g==;24:VwApHriwqDTBKO4v4c349Usea0wXShlsAOcdbys8iuHRxKlXkOUMUCP6tYQ1nwbkHDtd546H3C/p+izAR633Wy/jitk/xm7M4iP9aS+WkSY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2016 12:40:46.4787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 05:32:48PM +0000, Will Deacon wrote: > On Thu, Feb 18, 2016 at 05:50:12PM +0100, Jan Glauber wrote: > > Add a compatible string for the Cavium ThunderX PMU. > > Stupid question, but is "thunder" the name of the CPU or the SoC or ...? > > Whatever we use to describe the PMU, should probably also identify the > CPU uniquely. The CPU is currently: compatible = "cavium,thunder", "arm,armv8"; We clearly need better names in case of a subsequent CPU, but for now I think we should stick to the existing name. Jan > Will > > > Signed-off-by: Jan Glauber > > --- > > Documentation/devicetree/bindings/arm/pmu.txt | 1 + > > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt > > index 5651883..d3999a1 100644 > > --- a/Documentation/devicetree/bindings/arm/pmu.txt > > +++ b/Documentation/devicetree/bindings/arm/pmu.txt > > @@ -25,6 +25,7 @@ Required properties: > > "qcom,scorpion-pmu" > > "qcom,scorpion-mp-pmu" > > "qcom,krait-pmu" > > + "cavium,thunder-pmu" > > - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu > > interrupt (PPI) then 1 interrupt should be specified. > > > > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > index 9cb7cf9..2eb9b22 100644 > > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > > @@ -360,6 +360,11 @@ > > <1 10 0xff01>; > > }; > > > > + pmu { > > + compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; > > + interrupts = <1 7 4>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > #address-cells = <2>; > > -- > > 1.9.1 > >