From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbcBVPJG (ORCPT ); Mon, 22 Feb 2016 10:09:06 -0500 Received: from mail.kernel.org ([198.145.29.136]:33702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbcBVPJD (ORCPT ); Mon, 22 Feb 2016 10:09:03 -0500 Date: Mon, 22 Feb 2016 12:08:59 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Andi Kleen Subject: Re: [PATCH 1/5] perf tools: Fix assertion failure on dynamic entry Message-ID: <20160222150859.GC12977@kernel.org> References: <1456064558-13086-1-git-send-email-namhyung@kernel.org> <20160221173732.GF10701@krava.homerouter.cpe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160221173732.GF10701@krava.homerouter.cpe> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Feb 21, 2016 at 06:37:32PM +0100, Jiri Olsa escreveu: > On Sun, Feb 21, 2016 at 11:22:34PM +0900, Namhyung Kim wrote: > > The dynamic entry is created for each field in a tracepoint event. > > Since they have no fixed hpp format index, it should skip when > > perf_hpp__reset_width() is called. > > > > This caused following assertion failure.. > > > > $ perf record -e sched:sched_switch -a sleep 1 > > > > $ perf report -s comm,next_pid --stdio > > perf: ui/hist.c:651: perf_hpp__reset_width: > > Assertion `!(fmt->idx >= PERF_HPP__MAX_INDEX)' failed. > > > > Signed-off-by: Namhyung Kim > > Acked-by: Jiri Olsa Thanks, tested and applied the series, - Arnaldo