From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752443AbcBVTIf (ORCPT ); Mon, 22 Feb 2016 14:08:35 -0500 Received: from mga14.intel.com ([192.55.52.115]:60405 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbcBVTId (ORCPT ); Mon, 22 Feb 2016 14:08:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,485,1449561600"; d="scan'208";a="751110413" Date: Mon, 22 Feb 2016 21:08:28 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: James Morris , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net, Wilck@intel.com, Martin Subject: Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Message-ID: <20160222190828.GA32231@intel.com> References: <20160220081705.GA12981@intel.com> <20160222145023.GA28365@intel.com> <20160222175245.GA22828@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160222175245.GA22828@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 10:52:45AM -0700, Jason Gunthorpe wrote: > On Mon, Feb 22, 2016 at 04:50:23PM +0200, Jarkko Sakkinen wrote: > > > I already pushed a fix to my master for this issue: > > > > https://github.com/jsakkine/linux-tpmdd/commit/6386544ad7bceb3d0248b85da29d4d99eebe9161 > > The goal is to reduce the number of #ifdef'd code segments so we have > fewer problems in future with a large .config test matrix. > > I'd rather see a __maybe_unused annotation instead. Agreed that it's a better form but at this point it's probably revert the breaking change and move to that later on. Otherwise, I don't see reason not to include the patch that you authored to the release. I've used it in my test kernels for quite some time now and it has worked without issues. I sent my fix for review now. > Jason /Jarkko