From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755036AbcBVTdu (ORCPT ); Mon, 22 Feb 2016 14:33:50 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:45659 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbcBVTdt (ORCPT ); Mon, 22 Feb 2016 14:33:49 -0500 Date: Mon, 22 Feb 2016 22:33:33 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: Somya Anand , Shraddha Barke , Sudip Mukherjee , Amitoj Kaur Chawla , Wim de With , Alison Schofield , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch 6/6] Staging: gdm72xx: remove duplicate condition Message-ID: <20160222193333.GF23565@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We know "len" is not zero because we tested for that at the beginning of the function so this test can be removed. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 6d647d6..09bf64e 100644 --- a/drivers/staging/gdm72xx/gdm_wimax.c +++ b/drivers/staging/gdm72xx/gdm_wimax.c @@ -667,9 +667,8 @@ static void gdm_wimax_transmit_pkt(struct net_device *dev, char *buf, int len) cmd_len = be16_to_cpup((const __be16 *)&buf[2]); if (len < cmd_len + HCI_HEADER_SIZE) { - if (len) - netdev_err(dev, "%s: invalid length [%d/%d]\n", - __func__, cmd_len + HCI_HEADER_SIZE, len); + netdev_err(dev, "%s: invalid length [%d/%d]\n", + __func__, cmd_len + HCI_HEADER_SIZE, len); return; }