linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jessica Yu <jeyu@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Implement character sets for sscanf()
Date: Mon, 22 Feb 2016 14:39:21 -0500	[thread overview]
Message-ID: <20160222193921.GD31460@packer-debian-8-amd64.digitalocean.com> (raw)
In-Reply-To: <1456133234.13244.16.camel@linux.intel.com>

+++ Andy Shevchenko [22/02/16 11:27 +0200]:
>On Fri, 2016-02-19 at 20:20 -0500, Jessica Yu wrote:
>> Hi,
>>
>> This patch adds support for the '%[' conversion specifier for
>> sscanf().
>> Since functions that calculate substring lengths based on accepted or
>> rejected characters already exist in the kernel (namely strspn() and
>> strcspn()), it's not much of a stretch to add some basic support for
>> the
>> bracket '%[' conversion specifier for sscanf(). This is useful in
>> cases
>> where we'd like to match substrings delimited by something other than
>> spaces. The original motivation for this patch actually came from
>> livepatch
>> (https://lkml.org/lkml/2016/2/8/790), where we were trying to come up
>> with
>> a clean way to parse symbol names with substrings delimited by
>> periods and
>> commas.
>>
>> Patch based on linux-next-20160219.
>>
>> Here are some test cases:
>
>Test cases should land into lib/test_scanf.c and be submitted as a
>separate patch.
>
>Also, you have something misconfigured when you sent patches. git-send-
>email usually does a perfect job.

Thanks for the tip. Yeah, I had a small hiccup with git-send-email,
which is why the patchset came out like that :-\ In any case, the
attached test cases are more for the benefit of the patch reviewer,
not something I intended to be merged. For v2, I will just send the
single patch out.

Jessica

      reply	other threads:[~2016-02-22 19:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20  1:20 [PATCH 0/1] Implement character sets for sscanf() Jessica Yu
2016-02-22  9:27 ` Andy Shevchenko
2016-02-22 19:39   ` Jessica Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160222193921.GD31460@packer-debian-8-amd64.digitalocean.com \
    --to=jeyu@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).