From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755245AbcBVUOA (ORCPT <rfc822;w@1wt.eu>);
	Mon, 22 Feb 2016 15:14:00 -0500
Received: from smtp4-g21.free.fr ([212.27.42.4]:46031 "EHLO smtp4-g21.free.fr"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753786AbcBVUN5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 22 Feb 2016 15:13:57 -0500
Date: Mon, 22 Feb 2016 21:13:23 +0100
From: Alban <albeu@free.fr>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Aban Bedel <albeu@free.fr>, <linus.walleij@linaro.org>, <gnurou@gmail.com>,
        <michael.hennerich@analog.com>, <corbet@lwn.net>, <rjui@broadcom.com>,
        <shc_work@mail.ru>, <support.opensource@diasemi.com>,
        <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
        <bjorn.andersson@sonymobile.com>, <a.kesavan@samsung.com>,
        <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>,
        <bcm-kernel-feedback-list@broadcom.com>,
        <linux-arm-kernel@lists.infradead.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 10/61] gpio: ath79: Use devm_gpiochip_add_data() for
 gpio registration
Message-ID: <20160222211323.5c10533f@tock>
In-Reply-To: <1456150130-2668-11-git-send-email-ldewangan@nvidia.com>
References: <1456150130-2668-1-git-send-email-ldewangan@nvidia.com>
	<1456150130-2668-11-git-send-email-ldewangan@nvidia.com>
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 22 Feb 2016 19:37:59 +0530
Laxman Dewangan <ldewangan@nvidia.com> wrote:

> Use devm_gpiochip_add_data() for GPIO registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Alban Bedel <albeu@free.fr>
> ---
>  drivers/gpio/gpio-ath79.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index d13dd13..a6aad59 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -182,7 +182,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
>  		ctrl->chip.direction_output = ar934x_gpio_direction_output;
>  	}
>  
> -	err = gpiochip_add_data(&ctrl->chip, ctrl);
> +	err = devm_gpiochip_add_data(&pdev->dev, &ctrl->chip, ctrl);
>  	if (err) {
>  		dev_err(&pdev->dev,
>  			"cannot add AR71xx GPIO chip, error=%d", err);

With the patches already applied to the devel branch a few more changes
will be needed to remove the calls to gpiochip_remove() in the probe
error path and the remove callback.

Alban