From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755620AbcBVVuc (ORCPT ); Mon, 22 Feb 2016 16:50:32 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55877 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754742AbcBVVub (ORCPT ); Mon, 22 Feb 2016 16:50:31 -0500 Date: Mon, 22 Feb 2016 13:50:29 -0800 From: Stephen Boyd To: dinguyen@opensource.altera.com Cc: dinh.linux@gmail.com, mturquette@baylibre.com, mgerlach@opensource.altera.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: socfpga: allow for multiple parents on Arria10 periph clocks Message-ID: <20160222215029.GW4847@codeaurora.org> References: <1456170791-22718-1-git-send-email-dinguyen@opensource.altera.com> <20160222214700.GV4847@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160222214700.GV4847@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22, Stephen Boyd wrote: > On 02/22, dinguyen@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > There are some Arria10 clocks of type "altr,socfpga-a10-perip-clk" that can > > have multiple parents. Fix up the __socfpga_periph_init() to call > > of_clk_parent_fill() that will return the appropriate number of parents. > > > > Also, update __socfpga_gate_init() to call of_clk_parent_fill() helper > > function. > > > > Signed-off-by: Dinh Nguyen > > --- > > Applied to clk-next > Oops, spoke too soon: drivers/clk/socfpga/clk-periph-a10.c:113:27: warning: incorrect type in assignment (different base types) drivers/clk/socfpga/clk-periph-a10.c:113:27: expected char const *const *[assigned] parent_names drivers/clk/socfpga/clk-periph-a10.c:113:27: got char const *( * )[5] CC drivers/clk/socfpga/clk-periph-a10.o drivers/clk/socfpga/clk-periph-a10.c: In function ‘__socfpga_periph_init’: drivers/clk/socfpga/clk-periph-a10.c:113:20: warning: assignment from incompatible pointer type [enabled by default] -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project