From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337AbcBVWb5 (ORCPT ); Mon, 22 Feb 2016 17:31:57 -0500 Received: from mga03.intel.com ([134.134.136.65]:65241 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932301AbcBVWbz (ORCPT ); Mon, 22 Feb 2016 17:31:55 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,486,1449561600"; d="scan'208";a="892102472" Date: Mon, 22 Feb 2016 14:29:35 -0800 From: Yu-cheng Yu To: Dave Hansen Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, Andy Lutomirski , Borislav Petkov , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu Subject: Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Message-ID: <20160222222935.GA4232@test-lenovo> References: <1456167621-3974-1-git-send-email-yu-cheng.yu@intel.com> <56CB68C2.6010003@linux.intel.com> <20160222204828.GC4140@test-lenovo> <56CB8959.9090009@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CB8959.9090009@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2016 at 02:19:05PM -0800, Dave Hansen wrote: > On 02/22/2016 12:48 PM, Yu-cheng Yu wrote: > > It should have been: > > > > xsave->header.xfeatures = xfeatures | > > (xsave->header.xfeatures & XFEATURE_MASK_SUPERVISOR); > > > > I'll fix it. > > Can we break it out to make it more clear? > > /* > * The state that came in from userspace was user-state only. > * Mask all the user states out of 'xfeatures'. > */ > xsave->header.xfeatures &= XFEATURE_MASK_SUPERVISOR; > /* > * add back in the features that came in from userspace > */ > xsave->header.xfeatures |= xfeatures I will update it in the next version. Thanks!