From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756683AbcBWAz7 (ORCPT ); Mon, 22 Feb 2016 19:55:59 -0500 Received: from m50-132.163.com ([123.125.50.132]:40570 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756596AbcBWAz6 (ORCPT ); Mon, 22 Feb 2016 19:55:58 -0500 Date: Tue, 23 Feb 2016 08:55:04 +0800 From: Geliang Tang To: Greg Kroah-Hartman Cc: =?utf-8?Q?Rapha=C3=ABl?= Beamonte , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Geliang Tang Subject: Re: [PATCH 4/4] staging: rtl8192u: r8192U_core: use kmalloc_array instead of kmalloc Message-ID: <20160223005504.GA1750@localhost.localdomain> References: <6ada2cca5a646c6bea9a900a48109d10cdc45e85.1446991712.git.geliangtang@163.com> <9c21d2635419867a29994568c2dfda0b72cce63d.1446991712.git.geliangtang@163.com> <20160208035509.GA13031@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160208035509.GA13031@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CM-TRANSID: DNGowEBZpFvorctWkUjVAA--.27423S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7tr4DJr13trWrCF45Aw1DKFg_yoW8GF1rpr WUCwnakF1rZF1Du3Wjya1xJFy5Kw1rKFy0g342v348ZF9YvF1rXr98ZrWjvr4Svr1fGa1S qFWvk3W3Wr4DA3JanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRL0eLUUUUU= X-Originating-IP: [222.128.4.103] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbivwoYmVWBQRToXAAAsB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 07, 2016 at 07:55:09PM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 08, 2015 at 10:17:54PM +0800, Geliang Tang wrote: > > Use kmalloc_array instead of kmalloc to allocate memory for an array. > > > > Signed-off-by: Geliang Tang > > --- > > drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c > > index e06864f..07a1447 100644 > > --- a/drivers/staging/rtl8192u/r8192U_core.c > > +++ b/drivers/staging/rtl8192u/r8192U_core.c > > @@ -1725,8 +1725,8 @@ static short rtl8192_usb_initendpoints(struct net_device *dev) > > { > > struct r8192_priv *priv = ieee80211_priv(dev); > > > > - priv->rx_urb = kmalloc(sizeof(struct urb *) * (MAX_RX_URB + 1), > > - GFP_KERNEL); > > + priv->rx_urb = kmalloc_array(MAX_RX_URB + 1, sizeof(struct urb *), > > + GFP_KERNEL); > > I don't see the benefit here with this change, do you? It is highly likely that there is a checkpatch warning "kmalloc with multiplies" here. But the checkpatch script does not report this warning, I think it is because MAX_RX_URB is a macro, and there is a '+1' after it. Therefore although it passes,I think it still should be deemed as a warning. So to use kmalloc_array here seems better. Thanks. - Geliang