From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188AbcBWQKj (ORCPT ); Tue, 23 Feb 2016 11:10:39 -0500 Received: from muru.com ([72.249.23.125]:47150 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbcBWQKi (ORCPT ); Tue, 23 Feb 2016 11:10:38 -0500 Date: Tue, 23 Feb 2016 08:10:35 -0800 From: Tony Lindgren To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable Message-ID: <20160223161034.GZ13417@atomide.com> References: <1456235876-4088840-1-git-send-email-arnd@arndb.de> <1456235876-4088840-4-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456235876-4088840-4-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [160223 05:58]: > The modem pm handler in the ams-delta board uses regulator_enable() > but does not check for a successful return code: > > board-ams-delta.c:521:3: error: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Werror=unused-result] > > It is not easy to propagate that return code to the callers in > uart_configure_port/uart_suspend_port/uart_resume_port, unless > we change all UART drivers, and it is unclear what those would > do with the return code. > > Instead, this patch uses a runtime warning to replace the > compiletime warning. I have checked that the regulator in question > is hardcoded to a fixed-voltage GPIO regulator, and that should > never fail to get enabled if I understand the code right. Looks OK to me: Acked-by: Tony Lindgren