From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755125AbcBWUP0 (ORCPT ); Tue, 23 Feb 2016 15:15:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:42727 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbcBWUPY (ORCPT ); Tue, 23 Feb 2016 15:15:24 -0500 Date: Tue, 23 Feb 2016 14:15:20 -0600 From: Rob Herring To: Zhao Qiang Cc: oss@buserror.net, leoyang.li@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings. Message-ID: <20160223201520.GA3354@rob-hp-laptop> References: <1455757572-44955-1-git-send-email-qiang.zhao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455757572-44955-1-git-send-email-qiang.zhao@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote: > Add IC, SI and SIRAM document of QE to > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > > Signed-off-by: Zhao Qiang > --- > Changes for v2 > - Add interrupt-controller in Required properties > - delete address-cells and size-cells for qe-si and qe-siram > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > index 4f89302..84052a7 100644 > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt > @@ -69,6 +69,56 @@ Example: > }; > }; > > +* Interrupt Controller (IC) > + > +Required properties: > +- compatible : should be "fsl,qe-ic". > +- compatible : should be "fsl,qe-si". > +- compatible : should be "fsl,qe-siram". These compatible strings are all a bit generic and should have SoC specific compatible strings. Rob