public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brown <david.brown@linaro.org>
To: kernel-hardening@lists.openwall.com
Cc: PaX Team <pageexec@freemail.hu>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Laura Abbott <labbott@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kernel-hardening] Re: [PATCH] lkdtm: add test for executing .rodata
Date: Tue, 23 Feb 2016 13:31:31 -0700	[thread overview]
Message-ID: <20160223203131.GA1797@davidb.org> (raw)
In-Reply-To: <CAGXu5jKM5RZeTgTonscuLRg-+62S8UWcPbJABWqT4=7HOwb2bA@mail.gmail.com>

On Mon, Feb 22, 2016 at 12:46:28PM -0800, Kees Cook wrote:
>On Thu, Feb 18, 2016 at 1:27 PM, PaX Team <pageexec@freemail.hu> wrote:
>> On 18 Feb 2016 at 12:34, Ard Biesheuvel wrote:
>>
>>> However, that does not fix the issue Kees is trying to solve, where a
>>> .rodata section is emitted with the "x" bit set, which causes the
>>> linker to complain:
>>>
>>> /tmp/cc50ffWw.s: Assembler messages:
>>> /tmp/cc50ffWw.s:2: Warning: setting incorrect section attributes for
>>> .rodata.text
>>
>> in that case why not use a top-level asm statement to set the section
>> and its attributes (and compile the file with fno-toplevel-reorder)?
>
>GCC really wants to declare the section. :(

Why not then just use its mechanism to set the section on the code?

static void do_nothing_rodata(void)
	__attribute__((section(".rodata")))
{
	return;
}

David

  parent reply	other threads:[~2016-02-23 20:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 21:49 [PATCH] lkdtm: add test for executing .rodata Kees Cook
2016-02-17  1:06 ` Laura Abbott
2016-02-17 20:29   ` Kees Cook
2016-02-17 21:06     ` Kees Cook
2016-02-18 10:32     ` PaX Team
2016-02-18 11:34       ` Ard Biesheuvel
2016-02-18 11:55         ` Ard Biesheuvel
2016-02-18 12:07         ` Arnd Bergmann
2016-02-18 12:46           ` Ard Biesheuvel
2016-02-18 20:04             ` Kees Cook
2016-02-18 21:27         ` PaX Team
2016-02-22 20:46           ` Kees Cook
2016-02-22 23:21             ` PaX Team
2016-02-23 20:53               ` Kees Cook
2016-02-23 22:00                 ` PaX Team
2016-02-23 22:02                   ` Kees Cook
2016-02-23 20:31             ` David Brown [this message]
2016-02-23 20:51               ` [kernel-hardening] " Kees Cook
2016-02-17 21:44 ` Arnd Bergmann
2016-02-17 21:45   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223203131.GA1797@davidb.org \
    --to=david.brown@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeremy.linton@arm.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pageexec@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox