Re: [PATCH 04/27] mm, vmscan: Move lru_lock to the node

Johannes Weiner
2016-02-23T18:41:09Z

On Tue, Feb 23, 2016 at 03:04:27PM +0000, Mel Gorman wrote:
> Node-based reclaim requires node-based LRUs and locking. This is a
> preparation patch that just moves the lru_lock to the node so later patches
> are easier to review. It is a mechanical change but note this patch makes
> contention worse because the LRU lock is hotter and direct reclaim and kswapd
> can contend on the same lock even when reclaiming from different zones.
>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>

Reviewing mechanical patches like these is error prone, but nothing
obviously broken stands out to me here.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>