linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jessica Yu <jeyu@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: sscanf: implement basic character sets
Date: Tue, 23 Feb 2016 21:28:47 -0800	[thread overview]
Message-ID: <20160223212847.905209b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20160224051346.GD30919@packer-debian-8-amd64.digitalocean.com>

On Wed, 24 Feb 2016 00:13:47 -0500 Jessica Yu <jeyu@redhat.com> wrote:

> >> This patch adds support for the '%[' conversion specifier for sscanf().
> >> This is useful in cases where we'd like to match substrings delimited by
> >> something other than spaces. The original motivation for this patch
> >> actually came from a livepatch discussion (See: https://lkml.org/lkml/2016/2/8/790),
> >> where we were trying to come up with a clean way to parse symbol names with
> >> substrings delimited by periods and commas.
> >
> > It would be better to include the justification right here in the
> > changelog please. 
> > Not via some link-to-discussion and definitely not
> > below the ^--- marker!  It's very important.
> 
> Thanks for the corrections Andrew. I am however slightly confused, are
> you suggesting that I should provide a much more thorough explanation
> about the motivation here in the changelog (below the ^--- marker), or
> would this be better suited for a (separate) cover letter?

Just in the plain old changelog is good - if it was in [0/n] I'd only
move it into the changelog anyway.

And 99.9% of the stuff people put below ^--- is useful so I always end
up moving that into the changelog as well...

  reply	other threads:[~2016-02-24  5:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 20:38 [PATCH v3] sscanf: implement basic character sets Jessica Yu
2016-02-23 20:47 ` Kees Cook
2016-02-23 22:05 ` Andrew Morton
2016-02-24  5:13   ` Jessica Yu
2016-02-24  5:28     ` Andrew Morton [this message]
2016-02-23 22:47 ` [PATCH v3] " Rasmus Villemoes
2016-02-24  0:01   ` Rasmus Villemoes
2016-02-24  5:39   ` Jessica Yu
  -- strict thread matches above, loose matches on Subject: below --
2016-04-05 14:32 [PATCH v4] " Shahbaz Youssefi
2016-04-05 17:25 ` Jessica Yu
2016-02-26 20:20 [PATCH v4] " Jessica Yu
2016-02-26 20:28 ` Jessica Yu
2016-03-07 23:12   ` Jessica Yu
2016-03-07 23:24     ` Andrew Morton
2016-03-07 23:32       ` Rasmus Villemoes
2016-03-08  1:07       ` Jessica Yu
2016-03-02 23:49 ` [PATCH v4] " Rasmus Villemoes
2016-03-07 23:09   ` Jessica Yu
2016-02-22 21:24 [PATCH v2] " Jessica Yu
2016-02-23 10:56 ` Andy Shevchenko
2016-02-23 19:00   ` Kees Cook
2016-02-23 19:40     ` Jessica Yu
2016-02-23 19:26   ` Jessica Yu
2016-02-20  1:22 [PATCH 1/1] " Jessica Yu
2016-02-22 10:13 ` Andy Shevchenko
2016-02-22 17:51   ` Jessica Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223212847.905209b6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jeyu@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).