From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752206AbcBWX22 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Feb 2016 18:28:28 -0500
Received: from mail.kernel.org ([198.145.29.136]:55367 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751293AbcBWX20 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Feb 2016 18:28:26 -0500
Date: Tue, 23 Feb 2016 17:28:21 -0600
From: Rob Herring <robh@kernel.org>
To: Sergei Ianovich <ynvich@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
        "open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v4] spi: master driver to enable RTC on ICPDAS LP-8841
Message-ID: <20160223232821.GA14960@rob-hp-laptop>
References: <1456105630-28914-1-git-send-email-ynvich@gmail.com>
 <1456224272-4391-1-git-send-email-ynvich@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456224272-4391-1-git-send-email-ynvich@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 23, 2016 at 01:44:28PM +0300, Sergei Ianovich wrote:
> ICP DAS LP-8841 contains a DS-1302 RTC. This driver provides an SPI
> master which makes the RTC usable. The driver is not supposed to work
> with anything else.
> 
> The driver uses the standard MicroWire half-duplex transfer timing.
> Master output is set on low clock and sensed by the RTC on the rising
> edge. Master input is set by the RTC on the trailing edge and is sensed
> by the master on low clock.
> 
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> CC: Mark Brown <broonie@kernel.org>
> CC: Rob Herring <robh@kernel.org>
> 
>    v3..v4
>    fix Mark Brown review comments
>    * fix dependencies in Kconfig
> 
>    fix Rob Herring review comments
>    * rewrite binding description
>    * change binding and doc file names
>    * fix typo
> 
>    v2..v3 to fix Mark Brown review comments
>    * drop dependencies in Kconfig
>    * use #ifdef CONFIG_OF to allow build without DT
>    * drop empty driver->remove
> 
>    v1..v2 to fix Mark Brown review comments
>    * drop ifdef around MODULE_NAME
>    * use usleep_range directly
>    * drop empty master->cleanup
> ---
>  .../bindings/spi/icpdas-lp8841-spi-rtc.txt         |  54 +++++

Acked-by: Rob Herring <robh@kernel.org>