From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757900AbcBXHlF (ORCPT ); Wed, 24 Feb 2016 02:41:05 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35839 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755067AbcBXHlA (ORCPT ); Wed, 24 Feb 2016 02:41:00 -0500 Date: Wed, 24 Feb 2016 08:40:54 +0100 From: Ingo Molnar To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , Pedro Alves , Namhyung Kim , Bernd Petrovitsch , Chris J Arges , Andrew Morton , Jiri Slaby , Arnaldo Carvalho de Melo , David Vrabel , Borislav Petkov , Konrad Rzeszutek Wilk , Boris Ostrovsky , Jeremy Fitzhardinge , Chris Wright , Alok Kataria , Rusty Russell , Herbert Xu , "David S. Miller" , Pavel Machek , "Rafael J. Wysocki" , Len Brown , Matt Fleming , Alexei Starovoitov , netdev@vger.kernel.org, Ananth N Mavinakayanahalli , Anil S Keshavamurthy , Masami Hiramatsu , Gleb Natapov , Paolo Bonzini , kvm@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Waiman Long Subject: Re: [PATCH 00/33] Compile-time stack metadata validation Message-ID: <20160224074054.GA13199@gmail.com> References: <20160223081406.GA606@gmail.com> <20160223150155.GB15858@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160223150155.GB15858@treble.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > Hi Ingo, > > On Tue, Feb 23, 2016 at 09:14:06AM +0100, Ingo Molnar wrote: > > So I tried out this latest stacktool series and it looks mostly good for an > > upstream merge. > > > > To help this effort move forward I've applied the preparatory/fix patches that are > > part of this series to tip:x86/debug - that's 26 out of 31 patches. (I've > > propagated all the acks that the latest submission got into the changelogs.) > > Thanks very much for your review and for applying the fixes! > > A few issues relating to the merge: > > - The tip:x86/debug branch fails to build because it depends on > ec5186557abb ("x86/asm: Add C versions of frame pointer macros") which > is in tip:x86/asm. Indeed... > - As Pavel mentioned, the tip-bot seems to be spitting out garbage > emails from: > =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com. Yeah, hpa fixed that meanwhile. Due to the above bad base I rebased the tree (to a x86/asm base), so there will be a new round of (hopefully readable) tip-bot notifications. I'll push it out after a bit of testing. > > 5) > > > > Likewise, I think the CONFIG_STACK_VALIDATION=y Kconfig flag does not express that > > we do exception table checks as well - and it does not express all the other > > things we may check in object files in the future. > > > > Something like CONFIG_CHECK_OBJECT_FILES=y would express it, and the help text > > would list all the things the tool is able to checks for at the moment. > > Hm, I'm not really sure about this. Yes, the tool could potentially do > other types of checks, but is it necessary to lump them all together > into a single config option? It does have subcommands after all ;-) lol ;-) Ok, I'm fine with CONFIG_STACK_VALIDATION=y as well. Thanks, Ingo