From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbcBXLdU (ORCPT ); Wed, 24 Feb 2016 06:33:20 -0500 Received: from mail.skyhub.de ([78.46.96.112]:54320 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbcBXLdS (ORCPT ); Wed, 24 Feb 2016 06:33:18 -0500 Date: Wed, 24 Feb 2016 12:33:15 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, dougthompson@xmission.com, mchehab@osg.samsung.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, gong.chen@linux.intel.com, len.brown@intel.com, peterz@infradead.org, ak@linux.intel.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address Message-ID: <20160224113315.GB3888@pd.tnic> References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223123907.GD3673@pd.tnic> <56CCE3A6.3020406@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56CCE3A6.3020406@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote: > I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well. > So might be better to retain it here. Actually, I'm thinking, these all are - even if used in multiple files - all MCE-specific and therefore used in MCE/RAS-specific code. So they all should go into mce.h. Everything RAS includes that header so they're perfectly fine there... > (It comes up to 81 chars, but will ignore checkpatch in this case..) The 80-cols rule is not a hard one. Here's some food for thought: https://lkml.kernel.org/r/20160219095132.GA9681@gmail.com -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.