From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbcBXLht (ORCPT ); Wed, 24 Feb 2016 06:37:49 -0500 Received: from mail.skyhub.de ([78.46.96.112]:39520 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbcBXLhr (ORCPT ); Wed, 24 Feb 2016 06:37:47 -0500 Date: Wed, 24 Feb 2016 12:37:45 +0100 From: Borislav Petkov To: Aravind Gopalakrishnan Cc: tony.luck@intel.com, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, dougthompson@xmission.com, mchehab@osg.samsung.com, x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, gong.chen@linux.intel.com, len.brown@intel.com, peterz@infradead.org, ak@linux.intel.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error Message-ID: <20160224113744.GC3888@pd.tnic> References: <1455659111-32074-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1455659111-32074-4-git-send-email-Aravind.Gopalakrishnan@amd.com> <20160223121142.GA3673@pd.tnic> <56CCE510.1010906@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56CCE510.1010906@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2016 at 05:02:40PM -0600, Aravind Gopalakrishnan wrote: > On 2/23/16 6:11 AM, Borislav Petkov wrote: > >On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote: > >> /* AMD-specific bits */ > >>-#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */ > >>+#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */ > >/* uncorrected error, deferred exception */ > > > >sounds better to me. > > Hmm. Well, Deferred error is a separate class of error by itself. > It's neither Corrected in HW nor is it Uncorrected like a MCE. Let's consult the BKDG: "Deferred: deferred error. Read-write; Updated-by-hardware. Cold reset:0. 1=A deferred error was created. A deferred error is the result of an uncorrectable data error which did not immediately cause a processor exception; the data is poisoned and an exception is deferred until the data is loaded by a core. See 2.16.1.10 [Deferred Errors and Data Poisoning]." So it is an uncorrected error for which the raising of the error exception was deferred until consumption. > If you feel "Uncorrected error, deferred error exception" won;t be > confusing, that's OK with me. Why would it be confusing? It is describing exactly what a deferred error is, albeit a bit too laconic but people can find the longer description. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.