From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbcBXNRN (ORCPT ); Wed, 24 Feb 2016 08:17:13 -0500 Received: from mail.kernel.org ([198.145.29.136]:52369 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbcBXNRM (ORCPT ); Wed, 24 Feb 2016 08:17:12 -0500 Date: Wed, 24 Feb 2016 10:17:08 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Andi Kleen Subject: Re: [PATCH 04/15] perf mem: Add -u/-k options Message-ID: <20160224131708.GC24505@kernel.org> References: <1456303616-26926-1-git-send-email-jolsa@kernel.org> <1456303616-26926-5-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456303616-26926-5-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 24, 2016 at 09:46:45AM +0100, Jiri Olsa escreveu: > Add -u/-k (--all-user/--all-kernel) options to use > the perf record --all-user/--all-kernel options. Missing documentation update. -u/-k usage is ok, should be the same accross all tools, have to check that... Actually make that -U and -K, 'perf top' needs fixing in making -U mean --hide_kernel_symbols , will do. - Arnaldo > Link: http://lkml.kernel.org/n/tip-adxn5c48oe0gmjrjmq6we27q@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-mem.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c > index 9da09e058f4b..8a31b3f634d9 100644 > --- a/tools/perf/builtin-mem.c > +++ b/tools/perf/builtin-mem.c > @@ -62,6 +62,7 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) > int rec_argc, i = 0, j; > const char **rec_argv; > int ret; > + bool all_user = false, all_kernel = false; > struct option options[] = { > OPT_CALLBACK('e', "event", &mem, "event", > "event selector. use 'perf mem record -e list' to list available events", > @@ -69,13 +70,15 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) > OPT_UINTEGER('l', "ldlat", &perf_mem_events__loads_ldlat, "mem-loads latency"), > OPT_INCR('v', "verbose", &verbose, > "be more verbose (show counter open errors, etc)"), > + OPT_BOOLEAN('u', "--all-user", &all_user, "collect only user level data"), > + OPT_BOOLEAN('k', "--all-kernel", &all_kernel, "collect only kernel level data"), > OPT_END() > }; > > argc = parse_options(argc, argv, options, record_mem_usage, > PARSE_OPT_STOP_AT_NON_OPTION); > > - rec_argc = argc + 7; /* max number of arguments */ > + rec_argc = argc + 9; /* max number of arguments */ > rec_argv = calloc(rec_argc + 1, sizeof(char *)); > if (!rec_argv) > return -1; > @@ -104,6 +107,12 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) > rec_argv[i++] = perf_mem_events__name(j); > }; > > + if (all_user) > + rec_argv[i++] = "--all-user"; > + > + if (all_kernel) > + rec_argv[i++] = "--all-kernel"; > + > for (j = 0; j < argc; j++, i++) > rec_argv[i] = argv[j]; > > -- > 2.4.3