From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758104AbcBXNed (ORCPT ); Wed, 24 Feb 2016 08:34:33 -0500 Received: from mail.kernel.org ([198.145.29.136]:55535 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758076AbcBXNeb (ORCPT ); Wed, 24 Feb 2016 08:34:31 -0500 Date: Wed, 24 Feb 2016 10:34:28 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Stephane Eranian , Andi Kleen Subject: Re: [PATCH 13/15] perf script: Display data_src values Message-ID: <20160224133428.GE24505@kernel.org> References: <1456303616-26926-1-git-send-email-jolsa@kernel.org> <1456303616-26926-14-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456303616-26926-14-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 24, 2016 at 09:46:54AM +0100, Jiri Olsa escreveu: > Adding support to display data_src values, > for events with data_src data in sample. While testing patches in this series I noticed this: [root@jouet ~]# perf mem record -a Error: unknown switch `a' Usage: perf mem record [] [] or: perf mem record [] -- [] -e, --event event selector. use 'perf mem record -e list' to list available events -v, --verbose be more verbose (show counter open errors, etc) [root@jouet ~]# perf mem record -- -a ^C[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 3.149 MB perf.data (173 samples) ] [root@jouet ~]# Can't we imply the -- after 'record', i.e pass everything after 'record' to the underlying 'perf record' call? - Arnaldo