From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758145AbcBXNma (ORCPT ); Wed, 24 Feb 2016 08:42:30 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:48316 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757045AbcBXNm1 (ORCPT ); Wed, 24 Feb 2016 08:42:27 -0500 Date: Wed, 24 Feb 2016 15:42:19 +0200 From: Baruch Siach To: Laxman Dewangan Cc: linus.walleij@linaro.org, corbet@lwn.net, lee@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration Message-ID: <20160224134219.GI2225@tarshish> References: <1456319775-3216-1-git-send-email-ldewangan@nvidia.com> <1456319775-3216-39-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456319775-3216-39-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laxman Dewangan, On Wed, Feb 24, 2016 at 06:46:03PM +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and clean > error path. > > Signed-off-by: Laxman Dewangan > Cc: Baruch Siach > --- > drivers/pinctrl/pinctrl-digicolor.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index f1343d6..c18014d 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -326,17 +326,15 @@ static int dc_pinctrl_probe(struct platform_device *pdev) > > pmap->dev = &pdev->dev; > > - pmap->pctl = pinctrl_register(pctl_desc, &pdev->dev, pmap); > + pmap->pctl = devm_pinctrl_register(&pdev->dev, pctl_desc, pmap); > if (IS_ERR(pmap->pctl)) { > dev_err(&pdev->dev, "pinctrl driver registration failed\n"); > return PTR_ERR(pmap->pctl); > } > > ret = dc_gpiochip_add(pmap, pdev->dev.of_node); > - if (ret < 0) { > - pinctrl_unregister(pmap->pctl); > + if (ret < 0) > return ret; > - } > > return 0; Please simplify even more to just: return dc_gpiochip_add(pmap, pdev->dev.of_node); and remove the no longer used 'ret' variable. Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -