From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757297AbcBXQRO (ORCPT ); Wed, 24 Feb 2016 11:17:14 -0500 Received: from foss.arm.com ([217.140.101.70]:45107 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbcBXQRM (ORCPT ); Wed, 24 Feb 2016 11:17:12 -0500 Date: Wed, 24 Feb 2016 16:17:12 +0000 From: Will Deacon To: "Kirill A. Shutemov" Cc: Andrew Morton , Linus Torvalds , Gerald Schaefer , Christian Borntraeger , Martin Schwidefsky , Andrea Arcangeli , linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address Message-ID: <20160224161711.GA12471@arm.com> References: <1456329483-4220-1-git-send-email-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456329483-4220-1-git-send-email-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2016 at 06:58:03PM +0300, Kirill A. Shutemov wrote: > Sebastian Ott and Gerald Schaefer reported random crashes on s390. > It was bisected to my THP refcounting patchset. > > The problem is that pmdp_invalidated() called with wrong virtual > address. It got offset up by HPAGE_PMD_SIZE by loop over ptes. > > The solution is to introduce new variable to be used in loop and don't > touch 'haddr'. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Gerald Schaefer > Reported-by Sebastian Ott > --- > mm/huge_memory.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Looks good to me: Reviewed-by: Will Deacon Thanks, Will