From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758169AbcBXQ60 (ORCPT ); Wed, 24 Feb 2016 11:58:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49399 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758045AbcBXQ6Y (ORCPT ); Wed, 24 Feb 2016 11:58:24 -0500 Date: Wed, 24 Feb 2016 11:58:23 -0500 From: Mike Snitzer To: Bob Liu Cc: linux-kernel@vger.kernel.org, mpatocka@redhat.com, axboe@fb.com, j-nomura@ce.jp.nec.com, neilb@suse.com, dm-devel@redhat.com Subject: Re: dm: drop unnecessary assignment of md->queue Message-ID: <20160224165823.GA15480@redhat.com> References: <1456301738-16076-1-git-send-email-bob.liu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456301738-16076-1-git-send-email-bob.liu@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24 2016 at 3:15am -0500, Bob Liu wrote: > md->queue and q are the same thing in dm_init_request_based_queue() and > dm_init_request_based_blk_mq_queue(). > > Also drop the temporary struct request_queue *q. Yeah, I carried the extra assignment just as a form of documentation but your patch is correct (they aren't needed). I've rebased your patch ontop of linux-dm.git's 'dm-4.6' and have staged it in linux-next.