From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757787AbcBXTSQ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 14:18:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44565 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755555AbcBXTSN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 14:18:13 -0500
Date: Wed, 24 Feb 2016 20:18:05 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Stephane Eranian <eranian@google.com>, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 13/15] perf script: Display data_src values
Message-ID: <20160224191805.GC24004@krava.redhat.com>
References: <1456303616-26926-1-git-send-email-jolsa@kernel.org>
 <1456303616-26926-14-git-send-email-jolsa@kernel.org>
 <20160224133428.GE24505@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160224133428.GE24505@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 24, 2016 at 10:34:28AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Feb 24, 2016 at 09:46:54AM +0100, Jiri Olsa escreveu:
> > Adding support to display data_src values,
> > for events with data_src data in sample.
> 
> While testing patches in this series I noticed this:
> 
> [root@jouet ~]# perf mem record -a
>   Error: unknown switch `a'
> 
>  Usage: perf mem record [<options>] [<command>]
>     or: perf mem record [<options>] -- <command> [<options>]
> 
>     -e, --event <event>   event selector. use 'perf mem record -e list' to list available events
>     -v, --verbose         be more verbose (show counter open errors, etc)
> 
> [root@jouet ~]# perf mem record -- -a
> ^C[ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 3.149 MB perf.data (173 samples) ]
> 
> [root@jouet ~]#
> 
> 
> 
> Can't we imply the -- after 'record', i.e pass everything after 'record'
> to the underlying 'perf record' call?

I'll check on that, and try to have it in next version

jirka