From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758626AbcBXWJ3 (ORCPT ); Wed, 24 Feb 2016 17:09:29 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:32890 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757504AbcBXWJ1 (ORCPT ); Wed, 24 Feb 2016 17:09:27 -0500 Date: Wed, 24 Feb 2016 14:00:03 -0800 From: Olof Johansson To: Arnd Bergmann Cc: Lars Persson , arm@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, Lars Persson Subject: Re: [PATCH v3 0/6] arm: Add Artpec-6 SoC Message-ID: <20160224220003.GO10126@localhost> References: <2697188.EpDoHh0fx4@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2697188.EpDoHh0fx4@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hej, On Thu, Feb 11, 2016 at 05:20:27PM +0100, Arnd Bergmann wrote: > On Thursday 11 February 2016 17:06:15 Lars Persson wrote: > > Basic support for the Axis Artpec-6 ARM SoC. Timers, interrupts, UARTs and > > ethernet are wired up. > > > > Changes since v2: > > - Create a syscon binding for the system controller. > > - Clock patches split out to new patch series "clk: Add Artpec-6 SoC support". > > Looks all good to me now, impressive for v3 on a new platform port! > > We'll apply it in the next few days, unless further review comments come in. Indeed, nice and clean. I have two minor nits: 1) We prefix with ARM:, not arm:. I fixed this up for you. I also added ARM: dts: artpeg: ... on the dts changes. Not a huge deail on those. 2) Several of the patches lacked description. Subject pretty much says it all, but it's still nice to have a sentence or two as description. Again, not a huge deal, and I applied anyway, but for the future think about it. That being said, I've applied the series across next/soc, next/dt and next/defconfig. Thanks! -Olof