From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758461AbcBXX3i (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 18:29:38 -0500
Received: from mail.kernel.org ([198.145.29.136]:60282 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752031AbcBXX3g (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 18:29:36 -0500
Date: Wed, 24 Feb 2016 20:29:32 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        Don Zickus <dzickus@redhat.com>, Pekka Enberg <penberg@kernel.org>,
        Moinuddin Quadri <moin18@gmail.com>
Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)
Message-ID: <20160224232932.GF8720@kernel.org>
References: <1456326830-30456-1-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456326830-30456-1-git-send-email-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> Hello,
> 
> This patchset implements a new feature that collects hist entries in a
> hierachical manner.  That means lower-level entries belong to an
> upper-level entry.  The entry hierachy is built on the sort keys
> given, so users can set it whatever they want.  It only shows
> top-level entries first, and user can expand/collapse it dynamically.
> 
>  * Changes from v6)
>   - pass srcline, srcfile and trace_output of hist entry properly  (Jiri)
>   - use hist_entry__snprintf_alignment()  (Jiri)

Suggestion for further improvement:

perf top --hierarchy -e sched:sched_switch -s prev_comm,prev_pid,next_comm,next_pid

Will have four levels, would be nice to have just two, perhaps expressed
via:

perf top --hierarchy -e sched:sched_switch -s prev_comm+prev_pid,next_comm+next_pid

Where '+' would work as sort order separator, just like ',' but would
have special meaning for --hierarchy.

What do you think?

- Arnaldo