From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Henry Paulissen <draakje197@gmail.com>
Cc: linux-sunxi@googlegroups.com,
Linus Walleij <linus.walleij@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Andre Przywara <andre.przywara@arm.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Maxime Coquelin <maxime.coquelin@st.com>,
Lee Jones <lee@kernel.org>,
Hongzhou Yang <hongzhou.yang@mediatek.com>,
Fabian Frederick <fabf@skynet.be>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] Fix sun7i pin assignment for IRQ's
Date: Wed, 24 Feb 2016 16:54:12 -0800 [thread overview]
Message-ID: <20160225005412.GB4736@lukather> (raw)
In-Reply-To: <1456161251-2303-1-git-send-email-henry@nitronetworks.nl>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
Hi,
Usually, the patch title should be prefixed by the subsystem it
applies to so that maintainer and reviewers can spot it more
easily. In this case, it would be something like
pinctrl: sunxi: Fix sun7i pin assignment for IRQ's
On Mon, Feb 22, 2016 at 06:14:07PM +0100, Henry Paulissen wrote:
> After testing IRQ pins we found some bugs in the pinctrl declaration.
> Both PI* and PC* pins didn't work. PI* pins seemed to be connected
> to the wrong mux and PC* pins waren't working at all.
>
> Please note that the A20 soc manual is contradicting between version
> and even within the same document for both the PI and PC pins.
Which sections are in contradiction?
> Patch is based on testing with the hardware itself.
How did you test it? Using the sysfs API, or did you have any hardware
connected to it?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-25 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:14 [PATCH v6] Fix sun7i pin assignment for IRQ's Henry Paulissen
2016-02-25 0:54 ` Maxime Ripard [this message]
2016-02-25 14:16 ` Linus Walleij
[not found] ` <280e414e-546e-4a91-91a6-a4fa7157db49@googlegroups.com>
2016-02-25 17:42 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2016-02-22 17:07 Henry Paulissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225005412.GB4736@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=andre.przywara@arm.com \
--cc=draakje197@gmail.com \
--cc=fabf@skynet.be \
--cc=hongzhou.yang@mediatek.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.coquelin@st.com \
--cc=plagnioj@jcrosoft.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox