From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758724AbcBYBWP (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 20:22:15 -0500
Received: from mail.kernel.org ([198.145.29.136]:37945 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754505AbcBYBWO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 20:22:14 -0500
Date: Wed, 24 Feb 2016 22:22:07 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        Don Zickus <dzickus@redhat.com>, Pekka Enberg <penberg@kernel.org>,
        Moinuddin Quadri <moin18@gmail.com>
Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)
Message-ID: <20160225012207.GG8720@kernel.org>
References: <1456326830-30456-1-git-send-email-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1456326830-30456-1-git-send-email-namhyung@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> Hello,
> 
> This patchset implements a new feature that collects hist entries in a
> hierachical manner.  That means lower-level entries belong to an
> upper-level entry.  The entry hierachy is built on the sort keys
> given, so users can set it whatever they want.  It only shows
> top-level entries first, and user can expand/collapse it dynamically.

Some oddity: look at the line with 3.92%, it shows just the DSO... Ok, there
probably are no symbols above the specified threshold (--percent-limit 1), but
it is strange none the less, perhaps we can add something like:

#       Overhead  Command / Shared Object / Symbol      
# ..............  ..............................................................................................................................................
#
    72.83%        cc1       
       60.88%        cc1                    
           1.92%        [.] bitmap_set_bit
        7.37%        libc-2.22.so           
           2.90%        [.] _int_malloc
            |          
             --2.04%--0
                       _int_malloc

           1.13%        [.] _int_free
        3.92%        [kernel.vmlinux]       
           (no symbols >= 1%)


Original output:


[acme@jouet linux]$ perf report --hierarchy --percent-limit 1 | head -30
no symbols found in /usr/bin/gcc, maybe install a debug package?
# To display the perf.data header info, please use --header/--header-only options.
#
#
# Total Lost Samples: 0
#
# Samples: 10K of event 'cycles:ppp'
# Event count (approx.): 6703622666
#
#       Overhead  Command / Shared Object / Symbol      
# ..............  ..............................................................................................................................................
#
    72.83%        cc1       
       60.88%        cc1                    
           1.92%        [.] bitmap_set_bit
        7.37%        libc-2.22.so           
           2.90%        [.] _int_malloc
            |          
             --2.04%--0
                       _int_malloc

           1.13%        [.] _int_free
        3.92%        [kernel.vmlinux]       
     5.96%        as        
        3.19%        [kernel.vmlinux]       
        1.31%        as                     
     5.33%        conf      
        2.39%        conf                   
        1.52%        libc-2.22.so           
        1.37%        [kernel.vmlinux]       
     4.88%        ld        
[acme@jouet linux]$