Re: [PATCH v7 05/18] perf hists: Introduce hist_entry__filter()

[Namhyung Kim <namhyung@kernel.org>]

Hi Arnaldo,

On Wed, Feb 24, 2016 at 08:22:51PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 12:13:37AM +0900, Namhyung Kim escreveu:
> > +static int hist_entry__socket_filter(struct hist_entry *he, int type, const void *arg)
> > +{
> > +	int socket = *(const int *)arg;
> > +
> > +	if (type != HIST_FILTER__SOCKET)
> > +		return -1;
> > +
> > +	return socket >= 0 && he->socket != socket;
> 
> 'socket' is a function in sys/socket.h, and in older systems this file,
> tools/perf/util/sort.c, ends up including that header, causing:
> 
>   CC       /tmp/build/perf/util/sort.o
> cc1: warnings being treated as errors
> util/sort.c: In function ‘hist_entry__socket_filter’:
> util/sort.c:479: error: declaration of ‘socket’ shadows a global
> declaration
> /usr/include/sys/socket.h:105: error: shadowed declaration is here
> 
> I fixed it renaming it to 'sk'.

Oh, thank you for fixing this!

Thanks,
Namhyung