From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759331AbcBYCOk (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 21:14:40 -0500
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:35963 "EHLO
	lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759293AbcBYCOh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 21:14:37 -0500
X-Original-SENDERIP: 156.147.1.127
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 165.244.98.76
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Date: Thu, 25 Feb 2016 11:14:31 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>,
        Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>,
        Don Zickus <dzickus@redhat.com>, Pekka Enberg <penberg@kernel.org>,
        Moinuddin Quadri <moin18@gmail.com>
Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)
Message-ID: <20160225021431.GB18880@sejong>
References: <1456326830-30456-1-git-send-email-namhyung@kernel.org>
 <20160224232932.GF8720@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20160224232932.GF8720@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/02/25 11:14:32,
	Serialize by Router on LGEKRMHUB06/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/02/25 11:14:32,
	Serialize complete at 2016/02/25 11:14:32
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 24, 2016 at 08:29:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> > Hello,
> > 
> > This patchset implements a new feature that collects hist entries in a
> > hierachical manner.  That means lower-level entries belong to an
> > upper-level entry.  The entry hierachy is built on the sort keys
> > given, so users can set it whatever they want.  It only shows
> > top-level entries first, and user can expand/collapse it dynamically.
> > 
> >  * Changes from v6)
> >   - pass srcline, srcfile and trace_output of hist entry properly  (Jiri)
> >   - use hist_entry__snprintf_alignment()  (Jiri)
> 
> Suggestion for further improvement:
> 
> perf top --hierarchy -e sched:sched_switch -s prev_comm,prev_pid,next_comm,next_pid
> 
> Will have four levels, would be nice to have just two, perhaps expressed
> via:
> 
> perf top --hierarchy -e sched:sched_switch -s prev_comm+prev_pid,next_comm+next_pid
> 
> Where '+' would work as sort order separator, just like ',' but would
> have special meaning for --hierarchy.
> 
> What do you think?

Looks like a good addition.  To do that, a hist entry has to have its
own perf_hpp_list instead of a single perf_hpp_fmt.  I'll try to
implement it..

Thanks,
Namhyung