From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717AbcBYC2G (ORCPT ); Wed, 24 Feb 2016 21:28:06 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:33998 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759541AbcBYC2E (ORCPT ); Wed, 24 Feb 2016 21:28:04 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.204 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 25 Feb 2016 11:27:54 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Andi Kleen , Stephane Eranian , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri Subject: Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Message-ID: <20160225022754.GC18880@sejong> References: <1456326830-30456-1-git-send-email-namhyung@kernel.org> <20160225012207.GG8720@kernel.org> MIME-Version: 1.0 In-Reply-To: <20160225012207.GG8720@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/02/25 11:27:54, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/02/25 11:27:58, Serialize complete at 2016/02/25 11:27:58 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2016 at 10:22:07PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu: > > Hello, > > > > This patchset implements a new feature that collects hist entries in a > > hierachical manner. That means lower-level entries belong to an > > upper-level entry. The entry hierachy is built on the sort keys > > given, so users can set it whatever they want. It only shows > > top-level entries first, and user can expand/collapse it dynamically. > > Some oddity: look at the line with 3.92%, it shows just the DSO... Ok, there > probably are no symbols above the specified threshold (--percent-limit 1), but > it is strange none the less, perhaps we can add something like: > > # Overhead Command / Shared Object / Symbol > # .............. .............................................................................................................................................. > # > 72.83% cc1 > 60.88% cc1 > 1.92% [.] bitmap_set_bit > 7.37% libc-2.22.so > 2.90% [.] _int_malloc > | > --2.04%--0 > _int_malloc > > 1.13% [.] _int_free > 3.92% [kernel.vmlinux] > (no symbols >= 1%) Hmm.. makes sense. But the problem is that these non-entry lines hinder counting the number of (printed) entries which might break the output in some way. Maybe I can use a mock entry to work around it. I'll try to do something. :) Thanks, Namhyung > > > Original output: > > > [acme@jouet linux]$ perf report --hierarchy --percent-limit 1 | head -30 > no symbols found in /usr/bin/gcc, maybe install a debug package? > # To display the perf.data header info, please use --header/--header-only options. > # > # > # Total Lost Samples: 0 > # > # Samples: 10K of event 'cycles:ppp' > # Event count (approx.): 6703622666 > # > # Overhead Command / Shared Object / Symbol > # .............. .............................................................................................................................................. > # > 72.83% cc1 > 60.88% cc1 > 1.92% [.] bitmap_set_bit > 7.37% libc-2.22.so > 2.90% [.] _int_malloc > | > --2.04%--0 > _int_malloc > > 1.13% [.] _int_free > 3.92% [kernel.vmlinux] > 5.96% as > 3.19% [kernel.vmlinux] > 1.31% as > 5.33% conf > 2.39% conf > 1.52% libc-2.22.so > 1.37% [kernel.vmlinux] > 4.88% ld > [acme@jouet linux]$