From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Xen Devel <xen-devel@lists.xensource.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Rusty Russell <rusty@rustcorp.com.au>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
lguest@lists.ozlabs.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Vrabel <david.vrabel@citrix.com>,
Borislav Petkov <bp@alien8.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch
Date: Thu, 25 Feb 2016 09:10:44 +0100 [thread overview]
Message-ID: <20160225081044.GA11372@gmail.com> (raw)
In-Reply-To: <CALCETrW=dia7QCDhJVF8rnaKGDx_NNYVZqUNZSs9R87_o=h6NQ@mail.gmail.com>
* Andy Lutomirski <luto@amacapital.net> wrote:
> On Feb 24, 2016 12:33 AM, "Ingo Molnar" <mingo@kernel.org> wrote:
> >
> > For hard coded platform quirks I'd suggest we add x86_platform.quirks flags. For
> > example the F00F hack for Xen could be done via:
> >
> > x86_platform.quirks.idt_remap = 0;
> >
>
> Don't we unconditionally remap the IDT? I think Kees did it for
> general purpose hardening due to our complete inability to hide the
> IDT address. I.e. I think we can remove the f00f condition entirely.
Yeah, indeed - I only judged by the (limited) patch context and assumed the Xen
problem was with IDT remapping.
But what the quirk really does is only to avoid printing the f00f workaround -
i.e. a cosmetic change. I think we should just drop the paravirt_enabled() check.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-25 8:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 7:24 [PATCH v3 00/11] x86/init: replace paravirt_enabled() were possible Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-02-23 8:51 ` Ingo Molnar
2016-02-23 10:34 ` Luis R. Rodriguez
2016-02-23 20:41 ` Luis R. Rodriguez
2016-02-24 8:32 ` Ingo Molnar
2016-02-24 16:40 ` Andy Lutomirski
[not found] ` <CAB=NE6X0S-iXV_0t+JEE9zstE-+CfVZrU-WidyMk1dPJMi-hhQ@mail.gmail.com>
2016-02-25 1:29 ` Andy Lutomirski
2016-02-25 8:10 ` Ingo Molnar [this message]
2016-03-02 0:43 ` Luis R. Rodriguez
2016-03-02 19:40 ` Luis R. Rodriguez
2016-04-07 20:59 ` Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 02/11] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 03/11] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 04/11] x86/init: make ebda depend on PC subarch Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 05/11] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 06/11] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 07/11] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 08/11] x86/cpu/intel: replace paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 09/11] x86/boot: add BIT() to boot/bitops.h Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution Luis R. Rodriguez
2016-02-23 11:57 ` [Xen-devel] " David Vrabel
2016-02-23 18:10 ` Luis R. Rodriguez
2016-02-23 7:24 ` [PATCH v3 11/11] pnpbios: replace paravirt_enabled() check with subarch checks Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225081044.GA11372@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).